Uh oh!
There was an error while loading. Please reload this page.
vm: rename vm.Module to vm.SourceTextModule - #22007
Merged
Merged
Conversation
devsnek
commented
Jul 28, 2018
MemberAuthor
targos
commented
Jul 28, 2018
Member
Is it in preparation for adding other kinds of modules? |
MemberAuthor
@targos mostly... even if the spec doesn't define any more types we should still name them correctly. |
cjihrig
approved these changes
Jul 28, 2018
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
No opinion on the change, but the code LGTM.
targos
commented
Jul 28, 2018
Member
It doesn't have to be semver major. The API is experimental and behind a flag |
TimothyGu
approved these changes
Jul 28, 2018
addaleax
commented
Jul 28, 2018
Member
Not that you have to, but can you explain this? What kind of ES modules would not have some kind of source text associated with them? If this is to distinguish from e.g. WASM modules or so, maybe referring to the used language might be better? (Also, fyi: @nodejs/modules) |
Member
@addaleax At the last TC39 meeting, a new type of Module Records backed by JavaScript source called Dynamic Module Records was discussed, and it is now at Stage 1. Regardless of whether that proposal makes it all the way into the spec, |
ljharb
approved these changes
Jul 28, 2018
benjamingr
approved these changes
Jul 28, 2018
hybrist
approved these changes
Jul 28, 2018
BridgeAR
approved these changes
Jul 29, 2018
TimothyGu
commented
Jul 29, 2018
Member
@devsnek Would also be nice if my last comment (#22007 (comment)) is integrated into the commit message body. |
devsnek
commented
Jul 29, 2018
MemberAuthor
@TimothyGu will do when I land 👍 |
targos
approved these changes
Jul 29, 2018
targos
commented
Jul 29, 2018
Member
hiroppy
approved these changes
Jul 30, 2018
jasnell
approved these changes
Jul 30, 2018
jdalton
approved these changes
Jul 30, 2018
bmeck
approved these changes
Jul 30, 2018
At the last TC39 meeting, a new type of Module Records backed by JavaScript source called Dynamic Module Records was discussed, and it is now at Stage 1. Regardless of whether that proposal makes it all the way into the spec, SourceTextModule is indeed a more descriptive and accurate name for what this class represents. PR-URL: nodejs#22007 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
devsnek
commented
Jul 31, 2018
MemberAuthor
landed in 2bdcdfc |
targos pushed a commit
that referenced
this pull request
Aug 1, 2018
At the last TC39 meeting, a new type of Module Records backed by JavaScript source called Dynamic Module Records was discussed, and it is now at Stage 1. Regardless of whether that proposal makes it all the way into the spec, SourceTextModule is indeed a more descriptive and accurate name for what this class represents. PR-URL: #22007 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Merged
This was referenced Aug 1, 2018
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should have always been named SourceTextModule
/cc @nodejs/vm
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes