Uh oh!
There was an error while loading. Please reload this page.
tools: update to using dmn 1.0.11 - #22035
Closed
Trott wants to merge 1 commit into
Closed
Conversation
dmn 1.0.11 is available. Update update-eslint.sh to use it. Update update-babel-eslint.sh to use it too via npx. Add removeNPMAbsolutePaths to the latter while we're at it.
Trott
commented
Jul 31, 2018
MemberAuthor
@nodejs/linting |
targos
approved these changes
Jul 31, 2018
Trott
commented
Jul 31, 2018
MemberAuthor
These tools aren't run by CI so the lite CI should be sufficient. |
gireeshpunathil
approved these changes
Jul 31, 2018
cjihrig
approved these changes
Jul 31, 2018
refack
approved these changes
Jul 31, 2018
silverwind
approved these changes
Jul 31, 2018
lpinca
approved these changes
Jul 31, 2018
richardlau
approved these changes
Jul 31, 2018
richardlau
left a comment
Member
There was a problem hiding this comment.
I wonder if we can refactor these in the future so we only have to update the versions in one place rather than in both scripts.
trivikr
approved these changes
Aug 1, 2018
Trott added a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2018
dmn 1.0.11 is available. Update update-eslint.sh to use it. Update update-babel-eslint.sh to use it too via npx. Add removeNPMAbsolutePaths to the latter while we're at it. PR-URL: nodejs#22035 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott
commented
Aug 2, 2018
MemberAuthor
Landed in a3e511b |
targos pushed a commit
that referenced
this pull request
Aug 2, 2018
dmn 1.0.11 is available. Update update-eslint.sh to use it. Update update-babel-eslint.sh to use it too via npx. Add removeNPMAbsolutePaths to the latter while we're at it. PR-URL: #22035 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dmn 1.0.11 is available. Update update-eslint.sh to use it. Update
update-babel-eslint.sh to use it too via npx. Add removeNPMAbsolutePaths
to the latter while we're at it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes