Skip to content

[v10.x] test: remove outdated, non-functioning test - #22039

Closed
targos wants to merge 1 commit into
nodejs:v10.x-stagingfrom
targos:partial-backport-20894
Closed

[v10.x] test: remove outdated, non-functioning test#22039
targos wants to merge 1 commit into
nodejs:v10.x-stagingfrom
targos:partial-backport-20894

Conversation

@targos

@targostargos commented Jul 31, 2018

Copy link
Copy Markdown
Member

This is a cherry-pick of a commit from #20894 (semver-major PR). I need it to avoid conflicts with other subsequent test changes.

/cc @apapirovski @nodejs/timers

Original commit message:

The timers directory test, utilizing FakeTime, has not worked in
quite a while and is not truly testing Node.js behaviour. If a
similar test is necessary it would be better suited to libuv
on which Node.js relies for timers functionality.
PR-URL: https://github.com/nodejs/node/pull/20894
Fixes: https://github.com/nodejs/node/issues/10154
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

@apapirovski@targos
test: remove outdated, non-functioning test
f5f34d9
The timers directory test, utilizing FakeTime, has not worked in
quite a while and is not truly testing Node.js behaviour. If a
similar test is necessary it would be better suited to libuv
on which Node.js relies for timers functionality.
PR-URL: nodejs#20894Fixes: nodejs#10154
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@nodejs-github-bot

nodejs-github-bot commented Jul 31, 2018

Copy link
Copy Markdown
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/387/pipeline

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. v10.x labels Jul 31, 2018
@targostargos added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. and removed meta Issues and PRs related to the general management of the project. labels Jul 31, 2018
@targostargos mentioned this pull request Jul 31, 2018
Closed
3 tasks
targos pushed a commit that referenced this pull request Aug 2, 2018
@apapirovski@targos
test: remove outdated, non-functioning test
94746d6
The timers directory test, utilizing FakeTime, has not worked in
quite a while and is not truly testing Node.js behaviour. If a
similar test is necessary it would be better suited to libuv
on which Node.js relies for timers functionality.
PR-URL: #20894Fixes: #10154
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Backport-PR-URL: #22039
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@targos

targos commented Aug 2, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 94746d6

@targostargos closed this Aug 2, 2018
@targos
targos deleted the partial-backport-20894 branch August 2, 2018 19:54
@rvaggrvagg mentioned this pull request Aug 16, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@JungMinuJungMinuJungMinu approved these changes
+1 more reviewer
@sagirksagirksagirk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@addaleax@sagirk@JungMinu@apapirovski