Uh oh!
There was an error while loading. Please reload this page.
doc: fixup process.binding deprecation code - #22062
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
3 tasks
targos
approved these changes
Aug 1, 2018
targos
commented
Aug 1, 2018
Member
👍 this comment to fast-track |
cjihrig
approved these changes
Aug 1, 2018
apapirovski
approved these changes
Aug 1, 2018
ChALkeR
approved these changes
Aug 1, 2018
maclover7
approved these changes
Aug 1, 2018
jasnell
commented
Aug 1, 2018
MemberAuthor
targos
commented
Aug 1, 2018
Member
@jasnell CI-lite was automatically launched by the bot ;) |
jasnell
commented
Aug 1, 2018
MemberAuthor
heh, those are the same jobs aren't they ;-) ... force of habit starting it manually |
jasnell
commented
Aug 1, 2018
MemberAuthor
getting this landed :-) |
jasnell added a commit
that referenced
this pull request
Aug 1, 2018
PR-URL: #22062 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
jasnell
commented
Aug 1, 2018
MemberAuthor
Landed in dcfbedb |
targos pushed a commit
that referenced
this pull request
Aug 1, 2018
PR-URL: #22062 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This was referenced Aug 16, 2018
This was referenced May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup deprecation code from #22004
Missed assigning the actual code on landing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes