Skip to content

deps: cherry-pick 09bca09 from upstream V8 - #22068

Closed
mmarchini wants to merge 2 commits into
nodejs:masterfrom
mmarchini:v8-09bca095
Closed

deps: cherry-pick 09bca09 from upstream V8#22068
mmarchini wants to merge 2 commits into
nodejs:masterfrom
mmarchini:v8-09bca095

Conversation

@mmarchini

@mmarchinimmarchini commented Aug 1, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Original commit message:

[postmortem] add ScopeInfo and Context types
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).
R=bmeurer@google.com, yangguo@google.com
Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54768}

Refs: v8/v8@09bca09

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Matheus Marchini added 2 commits August 1, 2018 15:09
Matheus Marchini
deps: cherry-pick 09bca09 from upstream V8
b631495
Original commit message:
[postmortem] add ScopeInfo and Context types
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).
R=bmeurer@google.com, yangguo@google.com
Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: https://chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#54768}
Refs: v8/v8@09bca09
Matheus Marchini
fixup! deps: cherry-pick 09bca09 from upstream V8
c70098b
@nodejs-github-bot

nodejs-github-bot commented Aug 1, 2018

Copy link
Copy Markdown
Collaborator

@mmarchini build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/394/pipeline

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency. labels Aug 1, 2018
@mmarchinimmarchini changed the title V8 09bca095deps: cherry-pick 09bca09 from upstream V8Aug 1, 2018
@mmarchini

mmarchini commented Aug 1, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/16128/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/16152/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1561/ ✅

@jasnell

jasnell commented Aug 1, 2018

Copy link
Copy Markdown
Member

Can you please include the original commit message in the PR description above?

@mmarchini

mmarchini commented Aug 1, 2018

Copy link
Copy Markdown
ContributorAuthor

@jasnell done!

@mmarchini

mmarchini commented Aug 6, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed in a4c1cf5

mmarchini pushed a commit that referenced this pull request Aug 6, 2018
Matheus Marchini
deps: cherry-pick 09bca09 from upstream V8
a4c1cf5
Original commit message:
[postmortem] add ScopeInfo and Context types
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).
R=bmeurer@google.com, yangguo@google.com
Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: https://chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54768}
Refs: v8/v8@09bca09
PR-URL: #22068
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos

targos commented Aug 6, 2018

Copy link
Copy Markdown
Member

Should land with or after #21668 on v10.x-staging

@targos

targos commented Aug 6, 2018

Copy link
Copy Markdown
Member

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

@mmarchini

mmarchini commented Aug 6, 2018

Copy link
Copy Markdown
ContributorAuthor

Should land with or after #21668 on v10.x-staging

After, since this wasn't included in V8 6.8. Btw, I checked and this lands cleanly on v10.x-staging (at least for now, let's see after #21668 lands)

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

That's odd, in the PR GitHub shows the embedder string being bumped. I also don't know how we can prevent it in the future.

@targos

targos commented Aug 6, 2018

Copy link
Copy Markdown
Member

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

That's odd, in the PR GitHub shows the embedder string being bumped. I also don't know how we can prevent it in the future.

It happens sometimes, when master already had the bump from another PR. Instead of creating a conflict, git just makes the change a no-op.

@mmarchini

mmarchini commented Aug 8, 2018

Copy link
Copy Markdown
ContributorAuthor

Marked as dont-land-on-v8.x since SCOPE_INFO_TYPE, FIRST_CONTEXT_TYPE and LAST_CONTEXT_TYPE don't exist on V8 6.2.

targos pushed a commit that referenced this pull request Aug 11, 2018
Matheus Marchini@targos
deps: cherry-pick 09bca09 from upstream V8
e1dcb79
Original commit message:
[postmortem] add ScopeInfo and Context types
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).
R=bmeurer@google.com, yangguo@google.com
Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: https://chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54768}
Refs: v8/v8@09bca09
PR-URL: #22068
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@rvaggrvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
targos pushed a commit to targos/node that referenced this pull request Sep 7, 2018
Matheus Marchini@targos
deps: cherry-pick 09bca09 from upstream V8
30b0796
Original commit message:
[postmortem] add ScopeInfo and Context types
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).
R=bmeurer@google.com, yangguo@google.com
Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: https://chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#54768}
Refs: v8/v8@09bca09
PR-URL: nodejs#22068
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to targos/node that referenced this pull request Sep 7, 2018
Matheus Marchini@targos
deps: cherry-pick 09bca09 from upstream V8
127e703
Original commit message:
[postmortem] add ScopeInfo and Context types
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).
R=bmeurer@google.com, yangguo@google.com
Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: https://chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#54768}
Refs: v8/v8@09bca09
PR-URL: nodejs#22068
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@snyk-botsnyk-bot mentioned this pull request Apr 1, 2020
Open
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Matheus Marchini@rvagg
deps: cherry-pick 09bca09 from upstream V8
f8bc5d6
Original commit message:
[postmortem] add ScopeInfo and Context types
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).
R=bmeurer@google.com, yangguo@google.com
Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: https://chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54768}
Refs: v8/v8@09bca09
PR-URL: nodejs/node#22068
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.post-mortemIssues and PRs related to the post-mortem diagnostics of Node.js.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mmarchini@nodejs-github-bot@jasnell@targos@BridgeAR