Uh oh!
There was an error while loading. Please reload this page.
doc: update recommendations for createCipher - #22087
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
tniessen
commented
Aug 2, 2018
MemberAuthor
cc @nodejs/crypto |
yhwang
approved these changes
Aug 2, 2018
Trott
commented
Aug 2, 2018
Member
@nodejs/security-wg |
lirantal
commented
Aug 3, 2018
Member
LGTM |
jasnell
approved these changes
Aug 3, 2018
trivikr
approved these changes
Aug 5, 2018
tniessen added a commit
to tniessen/node
that referenced
this pull request
Aug 5, 2018
PR-URL: nodejs#22087 Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
tniessen
commented
Aug 5, 2018
MemberAuthor
Landed in 28c70ac. |
targos pushed a commit
that referenced
this pull request
Aug 6, 2018
PR-URL: #22087 Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that scrypt is supported, we should at least mention it as an alternative to PBKDF2.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes