Skip to content

deps: remove thread_local to fix V8 compilation - #22105

Closed
psmarshall wants to merge 1 commit into
nodejs:masterfrom
psmarshall:thread-local-fix
Closed

deps: remove thread_local to fix V8 compilation#22105
psmarshall wants to merge 1 commit into
nodejs:masterfrom
psmarshall:thread-local-fix

Conversation

@psmarshall

@psmarshallpsmarshall commented Aug 3, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This should fix compilation on macOS 10.10, addressing these issues:
nodejs/build#1415
Fixes: nodejs/build#1426

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Aug 3, 2018
@targos

Copy link
Copy Markdown
Member

Thanks. Maybe we should do that only in the backport PR?
That will be easier to test as well. Tests run on macOS 10.11 for master

@psmarshall

Copy link
Copy Markdown
ContributorAuthor

Yes, fine by me, I just didn't know which branch to target it to. Could you target the PR to the right place? I'm not able to change it 👍

@psmarshall
psmarshall changed the base branch from master to v10.x-stagingAugust 3, 2018 11:30
@psmarshall
psmarshall changed the base branch from v10.x-staging to masterAugust 3, 2018 11:42
@psmarshall

Copy link
Copy Markdown
ContributorAuthor

Oh wait I figured out how to change the target branch. I'm not sure how to set this up. We want this to land with the V8 6.8 backport onto 10.x-staging - but I can't target this to 10.x-staging until v8 6.8 is in there (otherwise the patch makes no sense..).

@targos

Copy link
Copy Markdown
Member

My suggestion was to add this change to the 6.8 backport PR

@targostargos mentioned this pull request Aug 4, 2018
2 tasks

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the V8 team are confident this does not have a negative impact. LTGM as it allows V8 6.8 to compile with OSX 1010 and provides an easier path for V8 6.8 landing in the 10.x line.

@psmarshall

Copy link
Copy Markdown
ContributorAuthor

This was picked into #21668, closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@psmarshall@targos@mhdawson@nodejs-github-bot