Uh oh!
There was an error while loading. Please reload this page.
deps: remove thread_local to fix V8 compilation - #22105
Conversation
1108cb6 to
a245736Comparetargos
commented
Aug 3, 2018
Thanks. Maybe we should do that only in the backport PR? |
psmarshall
commented
Aug 3, 2018
Yes, fine by me, I just didn't know which branch to target it to. Could you target the PR to the right place? I'm not able to change it 👍 |
psmarshall
commented
Aug 3, 2018
Oh wait I figured out how to change the target branch. I'm not sure how to set this up. We want this to land with the V8 6.8 backport onto 10.x-staging - but I can't target this to 10.x-staging until v8 6.8 is in there (otherwise the patch makes no sense..). |
targos
commented
Aug 3, 2018
My suggestion was to add this change to the 6.8 backport PR |
mhdawson
left a comment
There was a problem hiding this comment.
Assuming the V8 team are confident this does not have a negative impact. LTGM as it allows V8 6.8 to compile with OSX 1010 and provides an easier path for V8 6.8 landing in the 10.x line.
psmarshall
commented
Aug 16, 2018
This was picked into #21668, closing. |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis should fix compilation on macOS 10.10, addressing these issues:
nodejs/build#1415
Fixes: nodejs/build#1426