Skip to content

tls: preallocate SSL cipher array - #22136

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:crypto-preallocate-array
Closed

tls: preallocate SSL cipher array#22136
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:crypto-preallocate-array

Conversation

@tniessen

@tniessentniessen commented Aug 5, 2018

Copy link
Copy Markdown
Member

Since the number of elements is known, we can preallocate the array here to save a couple of dynamic allocations.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2018

Copy link
Copy Markdown
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/433/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Aug 5, 2018
@Trott

Trott commented Aug 5, 2018

Copy link
Copy Markdown
Member

@nodejs/security-wg

mcollina
mcollina approved these changes Aug 6, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen

tniessen commented Aug 7, 2018

Copy link
Copy Markdown
MemberAuthor

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16249/

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2018
@tniessen

tniessen commented Aug 9, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 4253e55.

@tniessentniessen closed this Aug 9, 2018
tniessen added a commit that referenced this pull request Aug 9, 2018
@tniessen
tls: preallocate SSL cipher array
4253e55
PR-URL: #22136
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Aug 11, 2018
@tniessen@targos
tls: preallocate SSL cipher array
b1a9cf7
PR-URL: #22136
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@rvaggrvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@tniessen@rvagg
tls: preallocate SSL cipher array
f989681
PR-URL: nodejs/node#22136
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@Trott@mcollina@addaleax@cjihrig