Uh oh!
There was an error while loading. Please reload this page.
assert: improve loose assertion message - #22155
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
So far the error message from a loose assertion is not always very informative and could be misleading. This is fixed by: * showing more from the actual error message * having a better error description * not using custom inspection * inspecting a higher depth * inspecting the full array instead of up to 100 entries
BridgeAR
commented
Aug 6, 2018
MemberAuthor
mcollina
commented
Aug 8, 2018
Member
Code LGTM. But isn't Is this something we need? |
jasnell
approved these changes
Aug 8, 2018
BridgeAR
commented
Aug 9, 2018
MemberAuthor
@mcollina it is doc deprecated but the problem is that it is still used relatively often. It is also not likely or currently intended to change the doc deprecation to a runtime deprecation. This is mainly a hot fix for some of the issues that the old version has for the case that people still use that. |
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Aug 9, 2018
So far the error message from a loose assertion is not always very informative and could be misleading. This is fixed by: * showing more from the actual error message * having a better error description * not using custom inspection * inspecting a higher depth * inspecting the full array instead of up to 100 entries PR-URL: nodejs#22155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR
commented
Aug 9, 2018
MemberAuthor
Landed in 1d859ef |
rvagg
commented
Aug 13, 2018
Member
@BridgeAR if this isn't semver-major (is it?) would you mind backporting to v10.x-staging please? There's a bit too much churn in there for this to apply nicely. |
targos
commented
Aug 19, 2018
Member
Ping @BridgeAR |
1 similar comment
targos
commented
Aug 29, 2018
Member
Ping @BridgeAR |
targos
commented
Sep 2, 2018
Member
Ping |
oyyd pushed a commit
to oyyd/node
that referenced
this pull request
Sep 25, 2018
So far the error message from a loose assertion is not always very informative and could be misleading. This is fixed by: * showing more from the actual error message * having a better error description * not using custom inspection * inspecting a higher depth * inspecting the full array instead of up to 100 entries PR-URL: nodejs#22155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR
commented
Oct 2, 2018
MemberAuthor
This relies on a semver-major change and should not be backported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far the error message from a loose assertion is not always very
informative and could be misleading. This is fixed by:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes