Uh oh!
There was an error while loading. Please reload this page.
Add multiple issue templates - #22215
Conversation
mscdex
commented
Aug 9, 2018
Are we sure links will render correctly with the exclamation point at the end of them? |
tniessen
commented
Aug 9, 2018
@mscdex They do in the GitHub markdown editor. |
There was a problem hiding this comment.
Please describe what is the problem you are trying to solve? Though not a native speaker.
There was a problem hiding this comment.
I think line 13 is sufficiently clear that line 14 isn't really necessary.
There was a problem hiding this comment.
How about: Please describe the problem you are trying to solve.?
There was a problem hiding this comment.
Please describe what do you want to happen?
There was a problem hiding this comment.
Maybe Please describe the desired behavior.?
sagirk
left a comment
There was a problem hiding this comment.
LGTM! 🎉
A few minor nits below:
There was a problem hiding this comment.
nit: able. -> able to. + same throughout
There was a problem hiding this comment.
nit:
able.->able to.+ same throughout
I'm mildly opposed to adding to.
If ending with able seems awkward or unclear, maybe as much as you're able -> as much as you can?
There was a problem hiding this comment.
+1 on as much as you can. Otherwise I would also stumble upon the sentence.
There was a problem hiding this comment.
nit: specify affected -> specify the affected
There was a problem hiding this comment.
nit: provide code -> provide the code
There was a problem hiding this comment.
I'm mildly opposed to this nit too. Just provide code.
There was a problem hiding this comment.
nit: Enter your issue details -> Please provide more details
tniessen
commented
Aug 10, 2018
@sagirk All of the nits you listed already existed in the old issue template. Can someone from nodejs/collaborators confirm that these should be changed? |
Trott
left a comment
There was a problem hiding this comment.
LGTM. I'm sure we'll want to iterate on these as we see how they work.
38fa282 to
166a1dcCompareThanks, @Trott. The filenames were generated by the GitHub wizard, I assume it is safe to change them, but I have no idea whether that would interfere with GitHub tools later on. |
devsnek
commented
Aug 10, 2018
@tniessen you can replace the first two dashes with a number e.g. |
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM but it would be nice to have the nit addressed.
There was a problem hiding this comment.
+1 on as much as you can. Otherwise I would also stumble upon the sentence.
| --- | ||
| If you have a question about Node.js that is not a bug report or feature | ||
| request, please post it in https://github.com/nodejs/help! |
There was a problem hiding this comment.
Maybe also add in this and the node.js org one that this will be closed if opened?
Fixes: #21812 PR-URL: #22215 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Aug 12, 2018
Landed in 3ce9275 |
Fixes: #21812 PR-URL: #22215 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs/node#21812 PR-URL: nodejs/node#22215 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
An initial attempt at using the new issue template tool provided by GitHub. I created the commits using the GitHub template wizard, I can take care of fixing the commit message if we decide to land this.
Looking forward to feedback and suggestions!
Fixes: #21812