Uh oh!
There was an error while loading. Please reload this page.
doc: add missing argv0 option for child_process.spawnSync - #22231
Closed
thw0rted wants to merge 1 commit into
Closed
doc: add missing argv0 option for child_process.spawnSync#22231thw0rted wants to merge 1 commit into
thw0rted wants to merge 1 commit into
Conversation
9 tasks
Trott
approved these changes
Aug 10, 2018
Trott
left a comment
Member
There was a problem hiding this comment.
Hi, @thw0rted. Welcome, and thanks for the pull request. It looks good to me.
It might be out of scope for this change, but I think the options should be alphabetized. Maybe if you're eager to do a second pull request or something.
/ping @nodejs/child_process @nodejs/documentation for reviews
Trott
commented
Aug 10, 2018
Member
BridgeAR
approved these changes
Aug 10, 2018
BridgeAR
commented
Aug 10, 2018
Member
Having them alphabetically would be nice but in that case the other entry has to be moved as well. This is in sync with the other documentation. |
lpinca
approved these changes
Aug 10, 2018
trivikr
commented
Aug 11, 2018
Member
Thank you @thw0rted for your contribution. The author for the last commit can be updated by following these steps |
vsemozhetbyt
approved these changes
Aug 11, 2018
vsemozhetbyt
commented
Aug 11, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
cjihrig
approved these changes
Aug 11, 2018
trivikr
approved these changes
Aug 12, 2018
vsemozhetbyt
commented
Aug 12, 2018
Contributor
Landed in 1f32cca |
vsemozhetbyt pushed a commit
that referenced
this pull request
Aug 12, 2018
PR-URL: #22231 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 12, 2018
PR-URL: #22231 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
firass111 pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
PR-URL: nodejs/node#22231 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The child_process docs include
argv0as an option forspawnbut notspawnSync. This is a documentation oversight, because the actual functions share the same options parsing logic.Checklist