Skip to content

perf_hooks: avoid memory leak on gc observer - #22241

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:perf-mem-leak
Closed

perf_hooks: avoid memory leak on gc observer#22241
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:perf-mem-leak

Conversation

@jasnell

@jasnelljasnell commented Aug 10, 2018

Copy link
Copy Markdown
Member

Fixes: #22229

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/495/pipeline

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 10, 2018
@jasnell

jasnell commented Aug 10, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/16342/

@jasnell

jasnell commented Aug 11, 2018

Copy link
Copy Markdown
MemberAuthor

Some odd failures in CI, trying again: https://ci.nodejs.org/job/node-test-pull-request/16364/

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
@trivikr

trivikr commented Aug 12, 2018

Copy link
Copy Markdown
Member

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/16381/

@gdams

gdams commented Aug 13, 2018

Copy link
Copy Markdown
Member

landed in: f6eab1a

@gdamsgdams closed this Aug 13, 2018
gdams pushed a commit that referenced this pull request Aug 13, 2018
@jasnellGeorge Adams
perf_hooks: avoid memory leak on gc observer
f6eab1a
Fixes: #22229
PR-URL: #22241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
@jasnell@rvagg
perf_hooks: avoid memory leak on gc observer
9e41032
Fixes: #22229
PR-URL: #22241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@rvaggrvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@jasnell@rvagg
perf_hooks: avoid memory leak on gc observer
f570c19
Fixes: nodejs/node#22229
PR-URL: nodejs/node#22241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@hashseedhashseedhashseed approved these changes
@gdamsgdamsgdams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jasnell@nodejs-github-bot@trivikr@gdams@addaleax@hashseed@cjihrig