Skip to content

inspector: tie objects lifetime to the thread they belong to - #22242

Merged
eugeneo merged 0 commit into
nodejs:masterfrom
eugeneo:objects_live_in_thread
Aug 14, 2018
Merged

inspector: tie objects lifetime to the thread they belong to#22242
eugeneo merged 0 commit into
nodejs:masterfrom
eugeneo:objects_live_in_thread

Conversation

@eugeneo

@eugeneoeugeneo commented Aug 10, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This is needed for #21364

@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

@eugeneo build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/496/pipeline

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 10, 2018
@trivikr

trivikr commented Aug 12, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16380/

@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 12, 2018
@eugeneo

eugeneo commented Aug 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Fixed Visual C++ compilation.

CI: https://ci.nodejs.org/job/node-test-pull-request/16424/

@eugeneo

eugeneo commented Aug 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Windows CI failure is #21425
LinuxOne is an infrastructure issue.

@eugeneoeugeneo closed this Aug 14, 2018
@eugeneo
eugeneo deleted the objects_live_in_thread branch August 14, 2018 16:09
@eugeneo

eugeneo commented Aug 14, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed as https://github.com/eugeneo/node/commit/7404a4dd42a45ae4d4dfb3474ce10cc5fef09e7c

@eugeneo
eugeneo merged commit 7404a4d into nodejs:masterAug 14, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
Eugene Ostroukhov@rvagg
inspector: tie objects lifetime to the thread they belong to
b97c73f
PR-URL: #22242
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
@rvaggrvagg mentioned this pull request Aug 15, 2018
Merged
@joyeecheungjoyeecheung mentioned this pull request Aug 15, 2018
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Eugene Ostroukhov@rvagg
inspector: tie objects lifetime to the thread they belong to
4c5dc6e
PR-URL: nodejs/node#22242
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
+1 more reviewer
@alexkozyalexkozyalexkozy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eugeneo@nodejs-github-bot@trivikr@alexkozy@jasnell