Skip to content

http2: explicitly disallow nested push streams - #22245

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-no-nested-pushstream
Closed

http2: explicitly disallow nested push streams#22245
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-no-nested-pushstream

Conversation

@jasnell

@jasnelljasnell commented Aug 10, 2018

Copy link
Copy Markdown
Member

Fixes: #19095

/cc @nodejs/http2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/500/pipeline

@nodejs-github-botnodejs-github-bot added dont-land-on-v6.x errors Issues and PRs related to JavaScript errors originated in Node.js core. http2 Issues or PRs related to the http2 subsystem. labels Aug 10, 2018
@jasnell

jasnell commented Aug 10, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/16347/

mcollina
mcollina approved these changes Aug 10, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
jasnell added a commit that referenced this pull request Aug 13, 2018
@jasnell
http2: explicitly disallow nested push streams
78584b6
Fixes: #19095
PR-URL: #22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jasnell

jasnell commented Aug 13, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 78584b6

@jasnelljasnell closed this Aug 13, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
@jasnell@rvagg
http2: explicitly disallow nested push streams
a562729
Fixes: #19095
PR-URL: #22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@rvaggrvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@jasnell@kjin
http2: explicitly disallow nested push streams
68e5ef9
Fixes: nodejs#19095
PR-URL: nodejs#22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@jasnell@kjin
http2: explicitly disallow nested push streams
f1e310e
Fixes: nodejs#19095
PR-URL: nodejs#22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@jasnell@BethGriggs
http2: explicitly disallow nested push streams
cc561cc
Fixes: #19095
Backport-PR-URL: #22850
PR-URL: #22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@jasnell@rvagg
http2: explicitly disallow nested push streams
7223a91
Fixes: nodejs/node#19095
PR-URL: nodejs/node#22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@trivikrtrivikrtrivikr approved these changes
@addaleaxaddaleaxAwaiting requested review from addaleax
@apapirovskiapapirovskiAwaiting requested review from apapirovski

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.errorsIssues and PRs related to JavaScript errors originated in Node.js core.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@nodejs-github-bot@mcollina@trivikr