Skip to content

http2: avoid race condition in OnHeaderCallback - #22256

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-avoid-race-condition
Closed

http2: avoid race condition in OnHeaderCallback#22256
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-avoid-race-condition

Conversation

@jasnell

@jasnelljasnell commented Aug 10, 2018

Copy link
Copy Markdown
Member

Rather than abort, close stream when stream does not exist in OnHeaderCallback

Fixes: #21416

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/513/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Aug 10, 2018
@jasnell

jasnell commented Aug 10, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/16356/

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
mcollina
mcollina approved these changes Aug 11, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams

gdams commented Aug 13, 2018

Copy link
Copy Markdown
Member

landed in: ac92a42

@gdamsgdams closed this Aug 13, 2018
gdams pushed a commit that referenced this pull request Aug 13, 2018
@jasnellGeorge Adams
http2: avoid race condition in OnHeaderCallback
ac92a42
Fixes: #21416
PR-URL: #22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
@jasnell@rvagg
http2: avoid race condition in OnHeaderCallback
83373e2
Fixes: #21416
PR-URL: #22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@rvaggrvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@jasnell@kjin
http2: avoid race condition in OnHeaderCallback
947d0c8
Fixes: nodejs#21416
PR-URL: nodejs#22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@jasnell@kjin
http2: avoid race condition in OnHeaderCallback
ee3e471
Fixes: nodejs#21416
PR-URL: nodejs#22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@jasnell@BethGriggs
http2: avoid race condition in OnHeaderCallback
5c3edd3
Fixes: #21416
Backport-PR-URL: #22850
PR-URL: #22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@jasnell@rvagg
http2: avoid race condition in OnHeaderCallback
cee78bf
Fixes: nodejs/node#21416
PR-URL: nodejs/node#22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@gdamsgdamsgdams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTTP2 module crashes and sometimes segfaults when running tests against it

6 participants

@jasnell@nodejs-github-bot@gdams@mcollina@addaleax@trivikr