Skip to content

doc: discuss special protocol handling - #22261

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:url-special-scheme
Closed

doc: discuss special protocol handling#22261
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:url-special-scheme

Conversation

@jasnell

@jasnelljasnell commented Aug 11, 2018

Copy link
Copy Markdown
Member

Fixes: #13523

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnelljasnell added doc Issues and PRs related to the documentations. whatwg-url Issues and PRs related to the WHATWG URL implementation. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 11, 2018
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/516/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Aug 11, 2018
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
@jasnell

jasnell commented Aug 11, 2018

Copy link
Copy Markdown
MemberAuthor

Please 👍 to fast-track

Trott
Trott approved these changes Aug 11, 2018
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some non-blocking nits.

Comment threaddoc/api/url.md Outdated
##### Special Schemes

The WHATWG URL Standard considers a handful of URL protocol schemes to be
"special" in terms of how those are parsed and serialized. When a URL is

@TrottTrottAug 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Italics instead of quotes around special.
  • those -> they

Comment threaddoc/api/url.md Outdated
```

However, changing from `http` to a hypothetical `fish` protocol does not
because the new protocol is not considered "special".

@TrottTrottAug 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No quotes around special.

Comment threaddoc/api/url.md Outdated

##### Special Schemes

The WHATWG URL Standard considers a handful of URL protocol schemes to be

@TrottTrottAug 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking the text WHATWG URL Standard to the standard itself would be useful here. It's already linked in two other places in the doc, so it's just a matter of changing the markdown to [WHATWG URL Standard][].

@Trott

Trott commented Aug 11, 2018

Copy link
Copy Markdown
Member

(Intentionally not approving fast-tracking here. There's enough new material here that it's probably worth not rushing the review process IMO and I'm unaware of any reason to rush landing it. I won't block fast-tracking but I'd ask people to consider carefully if this really needs to be fast-tracked.)

@Trott

Trott commented Aug 11, 2018

Copy link
Copy Markdown
Member

@jasnell You added the author ready tag before there were any approvals. Please only add the author ready tag after there is at least one Collaborator approval.

@jasnell

jasnell commented Aug 11, 2018

Copy link
Copy Markdown
MemberAuthor

Feel free to push your suggested edits to the PR.

@Trott

Trott commented Aug 11, 2018

Copy link
Copy Markdown
Member

Feel free to push your suggested edits to the PR.

👍 Done.

jasnell added a commit that referenced this pull request Aug 11, 2018
@jasnell
doc: discuss special protocol handling
58cf409
Fixes: #13523
PR-URL: #22261
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@jasnell

jasnell commented Aug 11, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 58cf409 (fast tracked with approval)

@jasnelljasnell closed this Aug 11, 2018
@TrottTrott mentioned this pull request Aug 12, 2018
Closed
targos pushed a commit that referenced this pull request Aug 12, 2018
@jasnell@targos
doc: discuss special protocol handling
3814e46
Fixes: #13523
PR-URL: #22261
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@benglbengl added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 13, 2018
@bengl

bengl commented Aug 13, 2018

Copy link
Copy Markdown
Member

^ Accidental tag removal and addition. Sorry!

@rvaggrvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@jasnell@rvagg
doc: discuss special protocol handling
1b41cd4
Fixes: nodejs/node#13523
PR-URL: nodejs/node#22261
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes
+2 more reviewers
@maclover7maclover7maclover7 approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.urlIssues and PRs related to the legacy built-in url module.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasnell@nodejs-github-bot@Trott@bengl@lpinca@maclover7@vsemozhetbyt@trivikr