Uh oh!
There was an error while loading. Please reload this page.
util: improve empty typed array inspection - #22284
Closed
BridgeAR wants to merge 3 commits into
Closed
Conversation
They should be aligned with all other empty objects. Therefore the whitespace is removed and they got a fast path for that.
jasnell
approved these changes
Aug 12, 2018
Member
I really don't want this to be semver-major but the output change may require it. Thoughts @nodejs/tsc? |
devsnek
approved these changes
Aug 12, 2018
devsnek
left a comment
Member
There was a problem hiding this comment.
lgtm without semver-major. the docs explicitly say not to use the output of util.inspect programmatically.
trivikr
approved these changes
Aug 12, 2018
addaleax
approved these changes
Aug 12, 2018
addaleax
left a comment
Member
There was a problem hiding this comment.
I think in this case it’s okay to land it as a non-breaking change if CITGM is okay with it.
(I’d generally keep it a case-by-case decision, though.)
BridgeAR
commented
Aug 13, 2018
MemberAuthor
lpinca
approved these changes
Aug 13, 2018
BridgeAR
commented
Aug 13, 2018
MemberAuthor
I just pushed another commit to prevent this path from being taken in case |
JungMinu
approved these changes
Aug 15, 2018
dnalborczyk pushed a commit
to dnalborczyk/node
that referenced
this pull request
Aug 15, 2018
They should be aligned with all other empty objects. Therefore the whitespace is removed and they got a fast path for that. PR-URL: nodejs#22284 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
BridgeAR
commented
Aug 15, 2018
MemberAuthor
BridgeAR
commented
Aug 15, 2018
MemberAuthor
CITGM runs came out fine. |
BridgeAR
commented
Aug 15, 2018
MemberAuthor
Landed in db6a246 |
targos
commented
Aug 19, 2018
Member
Should this be backported to |
targos
commented
Aug 19, 2018
Member
Landed easily after #21869 |
targos pushed a commit
that referenced
this pull request
Aug 19, 2018
They should be aligned with all other empty objects. Therefore the whitespace is removed and they got a fast path for that. PR-URL: #22284 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
targos pushed a commit
that referenced
this pull request
Sep 3, 2018
They should be aligned with all other empty objects. Therefore the whitespace is removed and they got a fast path for that. PR-URL: #22284 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They should be aligned with all other empty objects. Therefore the
whitespace is removed and they got a fast path for that.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes