Uh oh!
There was an error while loading. Please reload this page.
util: mark special entries as such - #22287
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
BridgeARforce-pushed
the
mark-inspect-special
branch
2 times, most recently
from
August 13, 2018 00:07
f766ef3 to
b361417CompareBridgeAR
commented
Aug 13, 2018
MemberAuthor
jasnell
approved these changes
Aug 13, 2018
devsnek
approved these changes
Aug 13, 2018
lpinca
reviewed
Aug 13, 2018
Member
There was a problem hiding this comment.
Is this assertion repeated on purpose?
Member
There was a problem hiding this comment.
removing author ready label because of this open question
MemberAuthor
There was a problem hiding this comment.
Thanks! Copy paste error :) It's now resolved.
trivikr
approved these changes
Aug 14, 2018
lpinca
approved these changes
Aug 14, 2018
trivikr
approved these changes
Aug 15, 2018
BridgeAR
commented
Aug 15, 2018
MemberAuthor
BridgeARforce-pushed
the
mark-inspect-special
branch
from
August 15, 2018 16:09
b62ab33 to
99b50c7CompareBridgeAR
commented
Aug 15, 2018
MemberAuthor
Rebased due to conflicts. |
This was referenced Aug 17, 2018
This adds the color code to special entries if colors are active.
BridgeARforce-pushed
the
mark-inspect-special
branch
from
August 19, 2018 13:24
99b50c7 to
2988330CompareMemberAuthor
Rebased again due to conflicts. CI https://ci.nodejs.org/job/node-test-pull-request/16569/ ✔️ |
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Aug 19, 2018
This adds the color code to special entries if colors are active. PR-URL: nodejs#22287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
commented
Aug 19, 2018
MemberAuthor
Landed in bd090f9 🎉 |
targos
commented
Aug 19, 2018
Member
Should this be backported to |
targos
commented
Aug 19, 2018
Member
Landed easily after #21869 |
targos pushed a commit
that referenced
this pull request
Aug 19, 2018
This adds the color code to special entries if colors are active. PR-URL: #22287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 3, 2018
This adds the color code to special entries if colors are active. PR-URL: #22287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the color code to special entries if colors are active.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes