Skip to content

v8: move process.binding('v8') to internalBinding - #22288

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:v8-internal-binding
Closed

v8: move process.binding('v8') to internalBinding#22288
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:v8-internal-binding

Conversation

@jasnell

@jasnelljasnell commented Aug 12, 2018

Copy link
Copy Markdown
Member

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jasnelljasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 12, 2018
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/539/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. labels Aug 12, 2018
@jasnelljasnell mentioned this pull request Aug 12, 2018
Closed
33 tasks
@BridgeAR
BridgeAR requested a review from a teamAugust 13, 2018 00:32
@BridgeAR

BridgeAR commented Aug 13, 2018

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/16410/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 13, 2018
jdalton
jdalton suggested changes Aug 13, 2018
View reviewed changes

@jdaltonjdalton left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding removals until migration is ironed out

jdalton
jdalton suggested changes Aug 13, 2018
View reviewed changes

@jdaltonjdalton left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[wrong button]

@jasnell

jasnell commented Aug 13, 2018

Copy link
Copy Markdown
MemberAuthor

@jdalton ... The require('v8') and process.binding('v8') bindings are explicitly not covered by existing semver rules.

See https://nodejs.org/dist/latest-v10.x/docs/api/v8.html#v8_v8:

The APIs and implementation are subject to change at any time.

Therefore, this PR should not be blocked by the transition discussion.

@jdalton

jdalton commented Aug 13, 2018

Copy link
Copy Markdown
Member

Therefore, this PR should not be blocked by the transition discussion.

I'd dig it if we could get a rough wag at usage before skipping deprecation processes.

@jasnell

jasnell commented Aug 13, 2018

Copy link
Copy Markdown
MemberAuthor

Technically the v8 module is not covered by the normal deprecation processes so they're not being skipped. However, once #22269 lands, I can add 'v8' to the whitelist for the time being.

@jasnell
jasnellforce-pushed the v8-internal-binding branch from 01a0230 to a2d45fbCompareAugust 15, 2018 02:26
@jasnell

jasnell commented Aug 15, 2018

Copy link
Copy Markdown
MemberAuthor

@jdalton ... added process.binding('v8') to the fallthrough whitelist

@jasnell

jasnell commented Aug 15, 2018

Copy link
Copy Markdown
MemberAuthor

New CI: https://ci.nodejs.org/job/node-test-pull-request/16462/

@jasnell

jasnell commented Aug 15, 2018

Copy link
Copy Markdown
MemberAuthor

ping @nodejs/tsc

@jasnell

jasnell commented Aug 16, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/16494/

@jasnell

jasnell commented Aug 16, 2018

Copy link
Copy Markdown
MemberAuthor

Another CI failure in linux-containered: https://ci.nodejs.org/job/node-test-commit-linux-containered/6330/

@jasnell
jasnellforce-pushed the v8-internal-binding branch 2 times, most recently from 8840799 to 9a0dcd0CompareAugust 16, 2018 21:27
@jasnell

jasnell commented Aug 16, 2018

Copy link
Copy Markdown
MemberAuthor

Trying CI yet again: https://ci.nodejs.org/job/node-test-pull-request/16500/

@Trott

Trott commented Aug 17, 2018

Copy link
Copy Markdown
Member

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16509/

This was referenced Aug 17, 2018
Closed
Closed
@jasnell

jasnell commented Aug 18, 2018

Copy link
Copy Markdown
MemberAuthor

New CI: https://ci.nodejs.org/job/node-test-pull-request/16531/

@jasnell
jasnellforce-pushed the v8-internal-binding branch from 9a0dcd0 to e0a0987CompareAugust 18, 2018 13:33
@jasnell

jasnell commented Aug 18, 2018

Copy link
Copy Markdown
MemberAuthor

Trying again: https://ci.nodejs.org/job/node-test-pull-request/16536/

@jasnell

jasnell commented Aug 18, 2018

Copy link
Copy Markdown
MemberAuthor

Trying arm fanned again because of an unrelated failure... https://ci.nodejs.org/job/node-test-commit-arm-fanned/3012/

@jasnell

jasnell commented Aug 18, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Arm... again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3023/

@jasnell
jasnellforce-pushed the v8-internal-binding branch from e0a0987 to c5a3d31CompareAugust 18, 2018 20:13
@jasnell

jasnell commented Aug 18, 2018

Copy link
Copy Markdown
MemberAuthor

Full CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/16555/

@Trott

Trott commented Aug 18, 2018

Copy link
Copy Markdown
Member

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16560/

jasnell added a commit to jasnell/node that referenced this pull request Aug 18, 2018
@jasnell
v8: move process.binding('v8') to internalBinding
892932f
PR-URL: nodejs#22288
Refs: nodejs#22160
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

jasnell commented Aug 18, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 892932f

@jasnelljasnell closed this Aug 18, 2018
@joyeecheungjoyeecheung mentioned this pull request Aug 20, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+5 more reviewers
@jdaltonjdaltonjdalton approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
@maclover7maclover7maclover7 approved these changes
@hiroppyhiroppyhiroppy approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.semver-majorPRs that contain breaking changes and should be released in the next major version.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@jasnell@nodejs-github-bot@BridgeAR@jdalton@Trott@addaleax@TimothyGu@cjihrig@maclover7@hiroppy@joyeecheung@devsnek@trivikr