Uh oh!
There was an error while loading. Please reload this page.
test,doc: fix async-hooks coverage doc for md lint (v10.x backport problem) - #22296
Closed
rvagg wants to merge 1 commit into
Closed
test,doc: fix async-hooks coverage doc for md lint (v10.x backport problem)#22296rvagg wants to merge 1 commit into
rvagg wants to merge 1 commit into
Conversation
nodejs#20894 / 2930bd1 was introduced on master which removed an offending line in this doc before linting was applied to test/ in nodejs#22221 / 56103ab. Since 20894 is semver-major, the full changes were not backported.
BridgeAR
approved these changes
Aug 13, 2018
vsemozhetbyt
approved these changes
Aug 13, 2018
vsemozhetbyt
commented
Aug 13, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
gdams
approved these changes
Aug 13, 2018
Trott
approved these changes
Aug 13, 2018
Trott
commented
Aug 13, 2018
Member
CI is green, fast tracking has been approved, and there are four sign-offs on this. Land at will, @rvagg! (I try to stay away from landing stuff on |
rvagg added a commit
that referenced
this pull request
Aug 13, 2018
#20894 / 2930bd1 was introduced on master which removed an offending line in this doc before linting was applied to test/ in #22221 / 56103ab. Since 20894 is semver-major, the full changes were not backported. PR-URL: #22296 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg
commented
Aug 13, 2018
MemberAuthor
excellent, thanks folks, merged into |
rvagg added a commit
that referenced
this pull request
Aug 15, 2018
#20894 / 2930bd1 was introduced on master which removed an offending line in this doc before linting was applied to test/ in #22221 / 56103ab. Since 20894 is semver-major, the full changes were not backported. PR-URL: #22296 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Aug 16, 2018
firass111 pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
nodejs/node#20894 / 2930bd1 was introduced on master which removed an offending line in this doc before linting was applied to test/ in nodejs/node#22221 / 56103ab. Since 20894 is semver-major, the full changes were not backported. PR-URL: nodejs/node#22296 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20894 / 2930bd1 was introduced on master which removed an offending line in this doc before linting was applied to test/ in #22221 / 56103ab. Since #20894 is semver-major, the full changes were not
backported.
It's either this or back out the md linting for test/ on v10.x for now I think.
Note that the change that applies lint-md to test/ isn't on v10.x-staging yet, nor are the other changes required to get test/ up to scratch, they're on the release proposal for 10.9.0 @ #22295 though. I'll put this on top of the rest of those commits and it'll be happy (have confirmed this, manually, CI won't tell us anything interesting about this PR as is).
@Trott you're probably the best person to look at this.