Port from joyent/node: `timers: fix timeout when added in timer's callback` by Fishrock123 · Pull Request #2232 · nodejs/node

Fishrock123 · 2015-07-24T00:46:36Z

We'll probably also want to port nodejs/node-v0.x-archive#25763

When a timer is added in another timer's callback, its underlying timer handle will be started with a timeout that is actually incorrect. The reason is that the value that represents the current time is not updated between the time the original callback is called and the time the added timer is processed by timers.listOnTimeout. That leads the logic in timers.listOnTimeout to do an incorrect computation that makes the added timer fire with a timeout of scheduledTimeout + timeSpentInCallback. This change fixes that and make timers scheduled within other timers' callbacks fire as expected. Fixes: nodejs/node-v0.x-archive#9333Fixes: nodejs/node-v0.x-archive#15447 PR: nodejs/node-v0.x-archive#17203 PR-URL: nodejs/node-v0.x-archive#17203 Reviewed-By: Fedor Indutny <fedor@indutny.com> Conflicts: lib/timers.js test/common.js

thefourtheye · 2015-07-24T01:36:07Z

This catch block and the function is not finished, I think

Oops, that was a merge conflict mis-resolve.

whitlockjc · 2015-07-24T15:47:57Z

I wouldn't mind helping port nodejs/node-v0.x-archive#25763 if it's not already been done.

Fishrock123 · 2015-07-24T16:17:25Z

@whitlockjc I'll be yeah, I figured I'd probably let Julien review it over there first.

Fishrock123 · 2015-07-27T16:36:11Z

Updated, PTAL @misterdjules / @bnoordhuis

bnoordhuis · 2015-07-27T18:34:55Z

Date.now() here and two lines up?

Hmm, in the new patch joyent/node will be using Timer.now() -- what's the difference between it and Date.now()?
https://github.com/joyent/node/pull/25763/files#diff-8736c5cbff21e1dee18b0c86d3d2689dR226

Timer.now() has a fighting chance of fitting in an SMI (a tagged integer), the return value of Date.now() is always a heap-allocated double.

bnoordhuis · 2015-07-27T18:40:34Z

LGTM with suggestions. The 100 ms timeout may end up being flaky on some of the CI machines.

Fishrock123 · 2015-07-28T04:18:46Z

Hmm, getting this with the patch locally:

=== release test-timers-unref-call === Path: parallel/test-timers-unref-call
Command: out/Release/iojs /Users/Jeremiah/Documents/io.js/test/parallel/test-timers-unref-call.js
--- TIMEOUT ---

I'm guessing that test exposes something wrong with this patch, since the test is not present in joyent/node. Perhaps the same bug nodejs/node-v0.x-archive#25763 is attempting to rectify?

Test origin commit: ebf9f29

thefourtheye · 2015-07-28T04:28:18Z

const? Also do we really need this? I mean we can directly use Date.now() in the following statement no?

Ah nice, true.

jasnell · 2015-08-23T16:08:12Z

@Fishrock123 ... what's the status on this one?

Fishrock123 · 2015-08-23T16:53:18Z

@jasnell was waiting on nodejs/node-v0.x-archive#25763

misterdjules · 2015-10-01T01:07:51Z

@Fishrock123 The failure in test/parallel/test-timers-unref-call.js is due to a problem with the original change being ported that executes nested timers callbacks in the same tick.

Since test/parallel/test-timers-unref-call.js overrides Timer.now to always advance the current time, and because the timer delay is initially 1ms (but really one "tick" or one Timer.now call with this override), the new timers added by setInterval's callback are always ready to fire, and always do indefinitely.

nodejs/node-v0.x-archive#25763 fixes this problem.

Fishrock123 · 2016-01-11T20:54:45Z

closing in favor of #3063

whitlockjc · 2016-07-07T20:08:56Z

#3063 has been updated to include this change and the test/parallel/test-timers-blocking-callback.js test per @misterdjules' request.

Fishrock123 added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Jul 24, 2015

Fishrock123 changed the title ~~timers: fix timeout when added in timer's callback~~Port from joyent/node: timers: fix timeout when added in timer's callbackJul 24, 2015

thefourtheye reviewed Jul 24, 2015
View reviewed changes

!fixup nits
6c0cb86

bnoordhuis reviewed Jul 27, 2015
View reviewed changes

!fixup address nits
dc7bcc0

thefourtheye reviewed Jul 28, 2015
View reviewed changes

snorp mentioned this pull request Aug 7, 2015
Timeouts sometimes not fired on Linux/ARM #2326
Closed

rvagg force-pushed the master branch from 11c25c2 to ba02bd0Compare September 6, 2015 11:55

Fishrock123 mentioned this pull request Sep 26, 2015
timers: fix processing of nested same delay timers #3063
Closed

Trott force-pushed the master branch from 1e896a6 to 082cc8dCompare December 27, 2015 02:00

Fishrock123 closed this Jan 11, 2016

misterdjules mentioned this pull request Jun 29, 2016
test: add tests for ensuring proper timer delays #7404
Closed
3 tasks

Uh oh!

Uh oh!

Conversation

Fishrock123 commented Jul 24, 2015

Uh oh!

thefourtheyeJul 24, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123Jul 24, 2015

Choose a reason for hiding this comment

Uh oh!

whitlockjc commented Jul 24, 2015

Uh oh!

Fishrock123 commented Jul 24, 2015

Uh oh!

Fishrock123 commented Jul 27, 2015

Uh oh!

bnoordhuisJul 27, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123Jul 27, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuisJul 27, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Jul 27, 2015

Uh oh!

Fishrock123 commented Jul 28, 2015

Uh oh!

thefourtheyeJul 28, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123Jul 28, 2015

Choose a reason for hiding this comment

Uh oh!

jasnell commented Aug 23, 2015

Uh oh!

Fishrock123 commented Aug 23, 2015

Uh oh!

misterdjules commented Oct 1, 2015

Uh oh!

Fishrock123 commented Jan 11, 2016

Uh oh!

whitlockjc commented Jul 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants