Uh oh!
There was an error while loading. Please reload this page.
deps: cherry-pick 9a23bdd from upstream V8 - #22338
Closed
Drieger wants to merge 1 commit into
Closed
Conversation
mmarchini
approved these changes
Aug 15, 2018
Contributor
@nodejs/v8 @nodejs/v8-update PTAL. Is there any chance we can backport this upstream to 6.8? |
ofrobots
commented
Aug 15, 2018
Contributor
The process to request an merge to an active upstream upstream branch is documented here. Specifically:
I've gone ahead and done the above. |
Original commit message: [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames Previously we were getting the code object from the stack, so printed incorrect position details for interpreted frames. BUG=v8:7916 Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9 Reviewed-on: https://chromium-review.googlesource.com/1126313 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#54253} Refs: v8/v8@9a23bddFixes: nodejs#21988
Driegerforce-pushed
the
stack_trace_with_abort_flag
branch
from
September 10, 2018 12:08
74d552a to
8b7def0CompareDrieger
commented
Sep 10, 2018
ContributorAuthor
Commit has landed in 6.9 |
BethGriggs pushed a commit
that referenced
this pull request
Oct 2, 2018
Original commit message: [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames Previously we were getting the code object from the stack, so printed incorrect position details for interpreted frames. BUG=v8:7916 Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9 Reviewed-on: https://chromium-review.googlesource.com/1126313 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54253} Refs: v8/v8@9a23bddFixes: #21988 PR-URL: #22418 Refs: #22338 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@9a23bdd
Fixes: #21988
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes