Skip to content

test: move test-timers-throw-reschedule to sequential - #22379

Closed
MylesBorins wants to merge 1 commit into
nodejs:v8.x-stagingfrom
MylesBorins:mv-test-timers-throw-reschedule
Closed

test: move test-timers-throw-reschedule to sequential#22379
MylesBorins wants to merge 1 commit into
nodejs:v8.x-stagingfrom
MylesBorins:mv-test-timers-throw-reschedule

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Aug 17, 2018

Copy link
Copy Markdown
Contributor

Refs: #21188

@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2018

Copy link
Copy Markdown
Collaborator

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/581/pipeline

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Aug 17, 2018
@MylesBorins

MylesBorins commented Aug 17, 2018

Copy link
Copy Markdown
ContributorAuthor

sigh... it seems like linuxone has decided to consistently fail on this test now, even with moving it to sequential

@apapirovski can you provide any insight into how we might be able to fix this?

@MylesBorins
MylesBorinsforce-pushed the mv-test-timers-throw-reschedule branch from ee2fcc3 to 19d91faCompareAugust 17, 2018 21:19
@MylesBorins

MylesBorins commented Aug 17, 2018

Copy link
Copy Markdown
ContributorAuthor

So the first run of this test failed on linuxone, the full CI run didn't.

/cc @nodejs/timers

Setting the test to flaky in this PR so it doesn't block the release

CI: https://ci.nodejs.org/job/node-test-pull-request/16521/

@MylesBorinsMylesBorins mentioned this pull request Aug 17, 2018
Closed
@joyeecheung

joyeecheung commented Aug 17, 2018

Copy link
Copy Markdown
Member

Oddly parallel/test-stdio-pipe-redirect also only fails on v8.x under load #22378

@joyeecheung

joyeecheung commented Aug 17, 2018•
edited
Loading

Copy link
Copy Markdown
Member

This test is no longer on master. The test was added in #20497 which targeted v8.x

@MylesBorins

MylesBorins commented Aug 17, 2018

Copy link
Copy Markdown
ContributorAuthor

@joyeecheungtest-timers-throw-reschedule is a test that landed directly on 8.x with a backport in #20497

@joyeecheungjoyeecheung mentioned this pull request Aug 17, 2018
Closed
@MylesBorins

MylesBorins commented Aug 17, 2018

Copy link
Copy Markdown
ContributorAuthor

landed in 01e2eba

MylesBorins added a commit that referenced this pull request Aug 17, 2018
@MylesBorins
test: move test-timers-throw-reschedule to sequential
01e2eba
This also sets the test as flaky
PR-URL: #22379
Refs: #21188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Sep 3, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@apapirovskiapapirovskiAwaiting requested review from apapirovski

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MylesBorins@nodejs-github-bot@joyeecheung@jasnell@apapirovski