Skip to content

http2: graduate from experimental - #22466

Closed
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:http2-graduate
Closed

http2: graduate from experimental#22466
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:http2-graduate

Conversation

@jasnell

@jasnelljasnell commented Aug 23, 2018

Copy link
Copy Markdown
Member

It's time.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/633/pipeline

@nodejs-github-botnodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Aug 23, 2018
@jasnelljasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 23, 2018
@jasnell
jasnell requested a review from a teamAugust 23, 2018 01:16
devsnek
devsnek approved these changes Aug 23, 2018
View reviewed changes

@devsnekdevsnek left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimothyGu
TimothyGu approved these changes Aug 23, 2018
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 For all who made it happen, thank you!

trivikr
trivikr approved these changes Aug 23, 2018
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!!!! 🎉

hiroppy
hiroppy approved these changes Aug 23, 2018
View reviewed changes

@hiroppyhiroppy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mcollina
mcollina approved these changes Aug 23, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina

mcollina commented Aug 23, 2018

Copy link
Copy Markdown
Member

I've added a dont-land-on-v8.x label because http2 on 8 is still far behind. This is not meant to be definitive, but it depends on those commits being backported. Feel free to remove once the two implementations are on par.

@mcollinamcollina mentioned this pull request Aug 23, 2018
Closed
11 tasks
mhdawson
mhdawson approved these changes Aug 23, 2018
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell

jasnell commented Aug 23, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/16710/

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 23, 2018
ChALkeR
ChALkeR reviewed Aug 24, 2018
View reviewed changes
Comment threaddoc/api/http2.md Outdated

@ChALkeRChALkeRAug 24, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs state when a module was introduced, but do not state when it was introduced out of experimental.
Any ideas how to improve this? /cc @nodejs/documentation
This is not blocking this PR from landing and it shouldn't depend on it, that is more like a related issue.

@jasnelljasnellAug 24, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should likely include it in the per-section changelog. I can update this to do so

@szmarczak

szmarczak commented Aug 24, 2018

Copy link
Copy Markdown
Member

#22486 needs to be merged before the release.

@jasnell

jasnell commented Aug 24, 2018

Copy link
Copy Markdown
MemberAuthor

#22486 is not blocking in terms of landing this PR. It should land within the next couple of days, however, and should make it into the next 10.x release

@szmarczak

szmarczak commented Aug 24, 2018

Copy link
Copy Markdown
Member

@jasnell That's what I said :P

@jasnelljasnell added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 25, 2018
jasnell added a commit that referenced this pull request Aug 25, 2018
@jasnell
http2: graduate from experimental
5d210d4
PR-URL: #22466
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

jasnell commented Aug 25, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 5d210d4!!!
🎉

@jasnelljasnell closed this Aug 25, 2018
@sogaanisogaani mentioned this pull request Aug 28, 2018
Open
addaleax pushed a commit that referenced this pull request Aug 28, 2018
@jasnell@addaleax
http2: graduate from experimental
137c6b5
PR-URL: #22466
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Sep 3, 2018
@jasnell@targos
http2: graduate from experimental
f77bbe8
PR-URL: #22466
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Sep 5, 2018
@targos
2018-09-06, Version 10.10.0 (Current)
8a45a6c
Notable changes:
* child_process:
* `TypedArray` and `DataView` values are now accepted as input by
`execFileSync` and `spawnSync`. #22409
* coverage:
* Native V8 code coverage information can now be output to disk by setting the
environment variable `NODE_V8_COVERAGE` to a directory. #22527
* deps:
* The bundled npm was upgraded to version 6.4.1. #22591
* Changelogs:
[6.3.0-next.0](https://github.com/npm/cli/releases/tag/v6.3.0-next.0)
[6.3.0](https://github.com/npm/cli/releases/tag/v6.3.0)
[6.4.0](https://github.com/npm/cli/releases/tag/v6.4.0)
[6.4.1](https://github.com/npm/cli/releases/tag/v6.4.1)
* fs:
* The methods `fs.read`, `fs.readSync`, `fs.write`, `fs.writeSync`,
`fs.writeFile` and `fs.writeFileSync` now all accept `TypedArray` and
`DataView` objects. #22150
* A new boolean option, `withFileTypes`, can be passed to to `fs.readdir` and
`fs.readdirSync`. If set to true, the methods return an array of directory
entries. These are objects that can be used to determine the type of each
entry and filter them based on that without calling `fs.stat`. #22020
* http2:
* The `http2` module is no longer experimental. #22466
* os:
* Added two new methods: `os.getPriority` and `os.setPriority`, allowing to
manipulate the scheduling priority of processes. #22394
* process:
* Added `process.allowedNodeEnvironmentFlags`. This object can be used to
programmatically validate and list flags that are allowed in the
`NODE_OPTIONS` environment variable. #19335
* src:
* Deprecated option variables in public C++ API. #22392
* Refactored options parsing. #22392
* vm:
* Added `vm.compileFunction`, a method to create new JavaScript functions from
a source body, with options similar to those of the other `vm` methods. #21571
* Added new collaborators:
* [lundibundi](https://github.com/lundibundi) - Denys Otrishko
PR-URL: #22716
@targostargos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@jasnell@targos
http2: graduate from experimental
2a3e26a
PR-URL: #22466
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Sep 6, 2018
@targos
2018-09-06, Version 10.10.0 (Current)
814a0c0
Notable changes:
* child_process:
* `TypedArray` and `DataView` values are now accepted as input by
`execFileSync` and `spawnSync`. #22409
* coverage:
* Native V8 code coverage information can now be output to disk by setting the
environment variable `NODE_V8_COVERAGE` to a directory. #22527
* deps:
* The bundled npm was upgraded to version 6.4.1. #22591
* Changelogs:
[6.3.0-next.0](https://github.com/npm/cli/releases/tag/v6.3.0-next.0)
[6.3.0](https://github.com/npm/cli/releases/tag/v6.3.0)
[6.4.0](https://github.com/npm/cli/releases/tag/v6.4.0)
[6.4.1](https://github.com/npm/cli/releases/tag/v6.4.1)
* fs:
* The methods `fs.read`, `fs.readSync`, `fs.write`, `fs.writeSync`,
`fs.writeFile` and `fs.writeFileSync` now all accept `TypedArray` and
`DataView` objects. #22150
* A new boolean option, `withFileTypes`, can be passed to to `fs.readdir` and
`fs.readdirSync`. If set to true, the methods return an array of directory
entries. These are objects that can be used to determine the type of each
entry and filter them based on that without calling `fs.stat`. #22020
* http2:
* The `http2` module is no longer experimental. #22466
* os:
* Added two new methods: `os.getPriority` and `os.setPriority`, allowing to
manipulate the scheduling priority of processes. #22407
* process:
* Added `process.allowedNodeEnvironmentFlags`. This object can be used to
programmatically validate and list flags that are allowed in the
`NODE_OPTIONS` environment variable. #19335
* src:
* Deprecated option variables in public C++ API. #22515
* Refactored options parsing. #22392
* vm:
* Added `vm.compileFunction`, a method to create new JavaScript functions from
a source body, with options similar to those of the other `vm` methods. #21571
* Added new collaborators:
* [lundibundi](https://github.com/lundibundi) - Denys Otrishko
PR-URL: #22716
targos added a commit that referenced this pull request Sep 6, 2018
@targos
2018-09-06, Version 10.10.0 (Current)
cdb3598
Notable changes:
* child_process:
* `TypedArray` and `DataView` values are now accepted as input by
`execFileSync` and `spawnSync`. #22409
* coverage:
* Native V8 code coverage information can now be output to disk by setting the
environment variable `NODE_V8_COVERAGE` to a directory. #22527
* deps:
* The bundled npm was upgraded to version 6.4.1. #22591
* Changelogs:
[6.3.0-next.0](https://github.com/npm/cli/releases/tag/v6.3.0-next.0)
[6.3.0](https://github.com/npm/cli/releases/tag/v6.3.0)
[6.4.0](https://github.com/npm/cli/releases/tag/v6.4.0)
[6.4.1](https://github.com/npm/cli/releases/tag/v6.4.1)
* fs:
* The methods `fs.read`, `fs.readSync`, `fs.write`, `fs.writeSync`,
`fs.writeFile` and `fs.writeFileSync` now all accept `TypedArray` and
`DataView` objects. #22150
* A new boolean option, `withFileTypes`, can be passed to to `fs.readdir` and
`fs.readdirSync`. If set to true, the methods return an array of directory
entries. These are objects that can be used to determine the type of each
entry and filter them based on that without calling `fs.stat`. #22020
* http2:
* The `http2` module is no longer experimental. #22466
* os:
* Added two new methods: `os.getPriority` and `os.setPriority`, allowing to
manipulate the scheduling priority of processes. #22407
* process:
* Added `process.allowedNodeEnvironmentFlags`. This object can be used to
programmatically validate and list flags that are allowed in the
`NODE_OPTIONS` environment variable. #19335
* src:
* Deprecated option variables in public C++ API. #22515
* Refactored options parsing. #22392
* vm:
* Added `vm.compileFunction`, a method to create new JavaScript functions from
a source body, with options similar to those of the other `vm` methods. #21571
* Added new collaborators:
* [lundibundi](https://github.com/lundibundi) - Denys Otrishko
PR-URL: #22716
targos added a commit that referenced this pull request Sep 6, 2018
@targos
2018-09-06, Version 10.10.0 (Current)
ed976d7
Notable changes:
* child_process:
* `TypedArray` and `DataView` values are now accepted as input by
`execFileSync` and `spawnSync`. #22409
* coverage:
* Native V8 code coverage information can now be output to disk by setting the
environment variable `NODE_V8_COVERAGE` to a directory. #22527
* deps:
* The bundled npm was upgraded to version 6.4.1. #22591
* Changelogs:
[6.3.0-next.0](https://github.com/npm/cli/releases/tag/v6.3.0-next.0)
[6.3.0](https://github.com/npm/cli/releases/tag/v6.3.0)
[6.4.0](https://github.com/npm/cli/releases/tag/v6.4.0)
[6.4.1](https://github.com/npm/cli/releases/tag/v6.4.1)
* fs:
* The methods `fs.read`, `fs.readSync`, `fs.write`, `fs.writeSync`,
`fs.writeFile` and `fs.writeFileSync` now all accept `TypedArray` and
`DataView` objects. #22150
* A new boolean option, `withFileTypes`, can be passed to to `fs.readdir` and
`fs.readdirSync`. If set to true, the methods return an array of directory
entries. These are objects that can be used to determine the type of each
entry and filter them based on that without calling `fs.stat`. #22020
* http2:
* The `http2` module is no longer experimental. #22466
* os:
* Added two new methods: `os.getPriority` and `os.setPriority`, allowing to
manipulate the scheduling priority of processes. #22407
* process:
* Added `process.allowedNodeEnvironmentFlags`. This object can be used to
programmatically validate and list flags that are allowed in the
`NODE_OPTIONS` environment variable. #19335
* src:
* Deprecated option variables in public C++ API. #22515
* Refactored options parsing. #22392
* vm:
* Added `vm.compileFunction`, a method to create new JavaScript functions from
a source body, with options similar to those of the other `vm` methods. #21571
* Added new collaborators:
* [lundibundi](https://github.com/lundibundi) - Denys Otrishko
PR-URL: #22716
This was referenced Sep 6, 2018
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Oct 3, 2018
@jasnell@kjin
http2: graduate from experimental
c5692e8
PR-URL: nodejs#22466
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@jasnell@kjin
http2: graduate from experimental
19e925b
PR-URL: nodejs#22466
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@jasnell@BethGriggs
http2: graduate from experimental
18a2b3d
Backport-PR-URL: #22850
PR-URL: #22466
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Nov 20, 2018
@BethGriggs@MylesBorins
2018-11-20, Version 8.13.0 'Carbon' (LTS)
90c7bfa
Notable changes:
* **assert**:
- backport some assert commits (Ruben Bridgewater)
[#23223](#23223)
* **deps**:
- upgrade to libuv 1.23.2 (cjihrig)
[#23336](#23336)
- V8: cherry-pick 64-bit hash seed commits (Yang Guo)
[#23274](#23274)
* **http**:
- added aborted property to request (Robert Nagy)
[#20094](#20094)
* **http2**:
- graduate from experimental (James M Snell)
[#22466](#22466)
PR-URL: #23974
MylesBorins pushed a commit that referenced this pull request Nov 20, 2018
@BethGriggs@MylesBorins
2018-11-20, Version 8.13.0 'Carbon' (LTS)
2c2e6ec
Notable changes:
* **assert**:
- backport some assert commits (Ruben Bridgewater)
[#23223](#23223)
* **deps**:
- upgrade to libuv 1.23.2 (cjihrig)
[#23336](#23336)
- V8: cherry-pick 64-bit hash seed commits (Yang Guo)
[#23274](#23274)
* **http**:
- added aborted property to request (Robert Nagy)
[#20094](#20094)
* **http2**:
- graduate from experimental (James M Snell)
[#22466](#22466)
PR-URL: #23974
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
@fortyforty mentioned this pull request Nov 22, 2018
Open
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BethGriggs@refack
2018-11-20, Version 8.13.0 'Carbon' (LTS)
7b4a62b
Notable changes:
* **assert**:
- backport some assert commits (Ruben Bridgewater)
[nodejs#23223](nodejs#23223)
* **deps**:
- upgrade to libuv 1.23.2 (cjihrig)
[nodejs#23336](nodejs#23336)
- V8: cherry-pick 64-bit hash seed commits (Yang Guo)
[nodejs#23274](nodejs#23274)
* **http**:
- added aborted property to request (Robert Nagy)
[nodejs#20094](nodejs#20094)
* **http2**:
- graduate from experimental (James M Snell)
[nodejs#22466](nodejs#22466)
PR-URL: nodejs#23974
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@ChALkeRChALkeRChALkeR approved these changes
@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+6 more reviewers
@ofrobotsofrobotsofrobots approved these changes
@apapirovskiapapirovskiapapirovski approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
@hiroppyhiroppyhiroppy approved these changes
@devsnekdevsnekdevsnek approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.notable-changePRs with changes that should be highlighted in changelogs.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

19 participants

@jasnell@nodejs-github-bot@mcollina@szmarczak@Trott@apapirovski@ofrobots@ChALkeR@addaleax@lpinca@TimothyGu@cjihrig@tniessen@hiroppy@joyeecheung@devsnek@BridgeAR@mhdawson@trivikr