Skip to content

(v10.x backport) crypto: add support for OCB mode for AEAD - #22473

Closed
tniessen wants to merge 1 commit into
nodejs:v10.x-stagingfrom
tniessen:backport-21447-to-v10.x
Closed

(v10.x backport) crypto: add support for OCB mode for AEAD#22473
tniessen wants to merge 1 commit into
nodejs:v10.x-stagingfrom
tniessen:backport-21447-to-v10.x

Conversation

@tniessen

@tniessentniessen commented Aug 23, 2018

Copy link
Copy Markdown
Member

Manual backport of #21447.

cc @targos@jasnell @nodejs/crypto

@tniessen
crypto: add support for OCB mode for AEAD
7ae8ab4
PR-URL: nodejs#21447
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2018

Copy link
Copy Markdown
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/638/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. v10.x labels Aug 23, 2018
@targos

targos commented Aug 24, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16728/

targos
targos approved these changes Aug 24, 2018
View reviewed changes

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@addaleax

addaleax commented Aug 27, 2018

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/16811/

@targos

targos commented Aug 28, 2018

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/16833/

@addaleax

addaleax commented Aug 28, 2018

Copy link
Copy Markdown
Member

Again: https://ci.nodejs.org/job/node-test-pull-request/16836/

@targos

targos commented Aug 29, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Landed in bc7dbc1

@targostargos closed this Aug 29, 2018
targos pushed a commit that referenced this pull request Aug 29, 2018
@tniessen@targos
crypto: add support for OCB mode for AEAD
bc7dbc1
Backport-PR-URL: #22473
PR-URL: #21447
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@tniessen@targos
crypto: add support for OCB mode for AEAD
59a6c60
Backport-PR-URL: #22473
PR-URL: #21447
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2018
@tniessen@targos
crypto: add support for OCB mode for AEAD
6465623
Backport-PR-URL: #22473
PR-URL: #21447
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tniessen@nodejs-github-bot@targos@addaleax