Uh oh!
There was an error while loading. Please reload this page.
src: export node_is_initialized - #225
Conversation
bnoordhuis
commented
Dec 31, 2014
I don't really want to export a global (before you ask: |
zcbenz
commented
Dec 31, 2014
How about putting |
piscisaureus
commented
Jan 10, 2015
That seems reasonable to me. |
zcbenz
commented
Jan 12, 2015
I have updated the patch. |
cjihrig
commented
Jan 20, 2015
@piscisaureus LGTY? |
bnoordhuis
commented
Jan 20, 2015
LGTM but a comment explaining why node_is_initialized is set where it's set makes it less likely to break in a future refactoring. |
This can make node_is_initialized correctly set to true for applications that use node::Init to embed iojs.
zcbenz
commented
Jan 20, 2015
I have added some comments in the code to make things clear. |
This can make node_is_initialized correctly set to true for applications that use node::Init to embed iojs. PR-URL: #225 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
bnoordhuis
commented
Jan 20, 2015
Thanks Cheng, landed in 22e1aea. |
This gives users that using io.js as external library a chance to set
node_is_initializedtotrue, otherwise it would impossible for them to use dynamic native modules.