Skip to content

n-api: remove idle_running from TsFn - #22520

Closed
ralphtheninja wants to merge 1 commit into
nodejs:masterfrom
ralphtheninja:napi-remove-idle-running
Closed

n-api: remove idle_running from TsFn#22520
ralphtheninja wants to merge 1 commit into
nodejs:masterfrom
ralphtheninja:napi-remove-idle-running

Conversation

@ralphtheninja

@ralphtheninjaralphtheninja commented Aug 25, 2018•
edited
Loading

Copy link
Copy Markdown

The idle_running member variable in TsFn is always false and can
therefore be removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Aug 25, 2018
Lars-Magnus Skog
n-api: remove idle_running from TsFn
50e5a2d
The idle_running member variable in TsFn is always false and can
therefore be removed.
@ralphtheninja
ralphtheninjaforce-pushed the napi-remove-idle-running branch from c043d20 to 50e5a2dCompareAugust 25, 2018 11:16
@addaleax

addaleax commented Aug 25, 2018

Copy link
Copy Markdown
Member

I think this might have to be rebased after #22259 lands, as a heads up

@gabrielschulhof

gabrielschulhof commented Aug 26, 2018

Copy link
Copy Markdown
Contributor

@addaleax I'll land this first, then land mine with a rebase.

@gabrielschulhof

gabrielschulhof commented Aug 26, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/16762/

@gabrielschulhof

gabrielschulhof commented Aug 27, 2018

Copy link
Copy Markdown
Contributor

Another CI: https://ci.nodejs.org/job/node-test-pull-request/16773/

@ralphtheninja

ralphtheninja commented Aug 27, 2018

Copy link
Copy Markdown
Author

Let me know if I should rebase it.

@gabrielschulhof

gabrielschulhof commented Aug 27, 2018

Copy link
Copy Markdown
Contributor

Another CI run: https://ci.nodejs.org/job/node-test-pull-request/16794/

@gabrielschulhof

gabrielschulhof commented Aug 27, 2018•
edited by addaleax
Loading

Copy link
Copy Markdown
Contributor

CI resumed as: https://ci.nodejs.org/job/node-test-pull-request/16799/ (:heavy_check_mark:)

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
@gabrielschulhof

gabrielschulhof commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

Landed in 5081d96.

pullBot pushed a commit to shakir-abdo/node that referenced this pull request Aug 28, 2018
Lars-Magnus SkogGabriel Schulhof
n-api: remove idle_running from TsFn
5081d96
The idle_running member variable in TsFn is always false and can
therefore be removed.
PR-URL: nodejs#22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
@ralphtheninja
ralphtheninja deleted the napi-remove-idle-running branch August 28, 2018 12:20
addaleax pushed a commit that referenced this pull request Aug 28, 2018
Lars-Magnus Skog@addaleax
n-api: remove idle_running from TsFn
698e90c
The idle_running member variable in TsFn is always false and can
therefore be removed.
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 3, 2018
Lars-Magnus Skog@targos
n-api: remove idle_running from TsFn
609ae33
The idle_running member variable in TsFn is always false and can
therefore be removed.
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targostargos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
Lars-Magnus Skog@targos
n-api: remove idle_running from TsFn
8eae030
The idle_running member variable in TsFn is always false and can
therefore be removed.
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
This was referenced Sep 6, 2018
Closed
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2018
Lars-Magnus SkogGabriel Schulhof
n-api: remove idle_running from TsFn
46118be
The idle_running member variable in TsFn is always false and can
therefore be removed.
PR-URL: nodejs#22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins pushed a commit that referenced this pull request Jan 18, 2019
Lars-Magnus Skog@MylesBorins
n-api: remove idle_running from TsFn
311e1f1
The idle_running member variable in TsFn is always false and can
therefore be removed.
Backport-PR-URL: #25002
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Lars-Magnus Skog@rvagg
n-api: remove idle_running from TsFn
09b88aa
The idle_running member variable in TsFn is always false and can
therefore be removed.
Backport-PR-URL: #25002
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
@MylesBorinsMylesBorins mentioned this pull request Mar 26, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@gabrielschulhofgabrielschulhofgabrielschulhof approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ralphtheninja@addaleax@gabrielschulhof@jasnell@devsnek@nodejs-github-bot