Uh oh!
There was an error while loading. Please reload this page.
build: do not lint fixtures in make lint-md - #22549
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
danbev
approved these changes
Aug 27, 2018
jasnell
approved these changes
Aug 27, 2018
Trott
commented
Aug 28, 2018
Member
I would prefer no changes to line 1093 and adding |
BridgeAR
approved these changes
Aug 31, 2018
addaleax
commented
Sep 2, 2018
Member
Removing |
BridgeAR
commented
Sep 5, 2018
Member
Ping @joyeecheung |
joyeecheungforce-pushed
the
lint-skip-fixtures
branch
from
September 15, 2018 06:05
68cf249 to
672474fComparejoyeecheung
commented
Sep 15, 2018
MemberAuthor
Updated to use the |
Trott
approved these changes
Sep 15, 2018
Member
Everything is good on CI except a known Windows flake. Windows re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20733/(Update: ✔️) |
refack
approved these changes
Sep 15, 2018
refack
commented
Sep 15, 2018
Contributor
Resume CI (with a special Windows trick): https://ci.nodejs.org/job/node-test-commit/21481/ |
joyeecheung
commented
Sep 16, 2018
MemberAuthor
Windows is still pretty red.. |
refack
commented
Sep 16, 2018
Contributor
Trott
commented
Sep 17, 2018
Member
Only red was Windows fanned. Known flaky. Here's a re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20753/ |
addaleax
commented
Sep 17, 2018
Member
joyeecheung
commented
Sep 17, 2018
MemberAuthor
Windows build is (finally) green |
MemberAuthor
Landed in bb9d788, thanks! |
joyeecheung added a commit
that referenced
this pull request
Sep 17, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 18, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 19, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 20, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful if we need to put markdown files in
test/fixtures(I was working on pulling the WPT there)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes