Uh oh!
There was an error while loading. Please reload this page.
doc: unify deprecation wording - #22555
Closed
tniessen wants to merge 2 commits into
Closed
Conversation
vsemozhetbyt
approved these changes
Aug 27, 2018
vsemozhetbyt
commented
Aug 27, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
jasnell
approved these changes
Aug 27, 2018
Trott
reviewed
Aug 27, 2018
| Type: Documentation-only | ||
| The option `produceCachedData` has been deprecated. Use | ||
| The option `produceCachedData` is deprecated. Use |
Member
There was a problem hiding this comment.
Micro-nit, can be ignored: There are five instances of suchAndSuch option and this is the only instance of option suchAndSuch. Change this to produceCacheData option rather than option produceCacheData.
Trott
approved these changes
Aug 27, 2018
addaleax
approved these changes
Aug 27, 2018
trivikr
approved these changes
Aug 27, 2018
lpinca
approved these changes
Aug 28, 2018
tniessen
commented
Aug 30, 2018
MemberAuthor
Landed in f417ea1. |
tniessen added a commit
that referenced
this pull request
Aug 30, 2018
PR-URL: #22555 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Aug 31, 2018
PR-URL: #22555 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22555 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22555 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @Trott in #22519 (comment): This is the only occurrence of
has been deprecated.Checklist