Uh oh!
There was an error while loading. Please reload this page.
build,win: remove unmatched endlocal statement - #22627
Merged
Merged
Conversation
refack
requested review from
addaleax, bzoz and joaocgreis
and removed request for
addaleaxAugust 31, 2018 17:08
refack
commented
Aug 31, 2018
ContributorAuthor
/CC @nodejs/platform-windows @nodejs/build-files |
2 tasks
addaleax
approved these changes
Aug 31, 2018
addaleax
left a comment
Member
There was a problem hiding this comment.
Commit message typo: orphan (or, alternatively, unmatched or sth like that)
refackforce-pushed
the
remove-vcbuild-orphen
branch
from
August 31, 2018 17:12
06d2f64 to
0ec9036Compareendlocal statementrefackforce-pushed
the
remove-vcbuild-orphen
branch
from
August 31, 2018 17:13
0ec9036 to
48edf2bComparerefack
commented
Aug 31, 2018
ContributorAuthor
Fixed. |
richardlau
approved these changes
Aug 31, 2018
cjihrig
approved these changes
Aug 31, 2018
BridgeAR
approved these changes
Sep 1, 2018
bzoz
approved these changes
Sep 3, 2018
ContributorAuthor
trivikr
approved these changes
Sep 4, 2018
Seems like it's a leftover from c403eeb PR-URL: nodejs#22627 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
refackforce-pushed
the
remove-vcbuild-orphen
branch
from
September 4, 2018 15:34
48edf2b to
4cea01aComparerefack
commented
Sep 4, 2018
ContributorAuthor
landed in 4cea01a |
targos pushed a commit
that referenced
this pull request
Sep 5, 2018
Seems like it's a leftover from c403eeb PR-URL: #22627 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 6, 2018
Seems like it's a leftover from c403eeb PR-URL: #22627 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like it's a leftover from c403eeb
Refs: #22582 (review)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes