Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky addons/callback-scope/test-resolve-async - #22664
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
addaleax
commented
Sep 2, 2018
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/16968/ Feel free to 👍 this comment if you approve of fast-tracking. |
tniessen
approved these changes
Sep 2, 2018
lundibundi
approved these changes
Sep 2, 2018
lundibundi
left a comment
Member
There was a problem hiding this comment.
LGTM. Whoever lands this please also addFixes: https://github.com/nodejs/node/issues/22668.
addaleaxforce-pushed
the
test-resolve-async
branch
from
September 3, 2018 12:37
081f134 to
f6e012bCompareaddaleaxforce-pushed
the
test-resolve-async
branch
from
September 3, 2018 12:41
f6e012b to
b85baf7CompareMemberAuthor
Okay, loosened the test a bit more here. New CI: https://ci.nodejs.org/job/node-test-pull-request/16987/ (:heavy_check_mark:) |
lpinca
approved these changes
Sep 3, 2018
gdams
approved these changes
Sep 4, 2018
jasnell
approved these changes
Sep 4, 2018
BridgeAR
approved these changes
Sep 5, 2018
refack
reviewed
Sep 5, 2018
| testResolveAsync().then(() => { called = true; }); | ||
| setTimeout(() => { assert(called); }, common.platformTimeout(50)); | ||
| process.on('beforeExit', () => { assert(called); }); |
Contributor
There was a problem hiding this comment.
Why not use common.mustCall? It uses essentially the same mechanism
Lines 428 to 429 in b85baf7
MemberAuthor
There was a problem hiding this comment.
The goal is to have no MakeCallback() calls coming from Node.js before the check is run, since those would also run the microtask queue. process.on('exit') would be too late for that, process.on('beforeExit') should be okay.
danbev
commented
Sep 7, 2018
Contributor
Landed in 4a5886c. |
danbev pushed a commit
that referenced
this pull request
Sep 7, 2018
Fixes: #22668 PR-URL: #22664 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit
that referenced
this pull request
Sep 7, 2018
Fixes: #22668 PR-URL: #22664 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example failure: https://ci.nodejs.org/job/node-test-commit-linux/21264/nodes=fedora-latest-x64/console
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes