Skip to content

deps: patch V8 to 6.8.275.32 - #22682

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:v8-patch-32
Closed

deps: patch V8 to 6.8.275.32#22682
targos wants to merge 1 commit into
nodejs:masterfrom
targos:v8-patch-32

Conversation

@targos

@targostargos commented Sep 4, 2018

Copy link
Copy Markdown
Member

Refs: v8/v8@6.8.275.30...6.8.275.32

@nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2018

Copy link
Copy Markdown
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/787/pipeline

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 4, 2018
@targos

targos commented Sep 4, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/17001/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1653/

@lin7sh

lin7sh commented Sep 4, 2018

Copy link
Copy Markdown

Just heard about Chrome 69 stable is out, the v8 version comes with it have Lifeoff baseline compiler for WASM, could you use that version instead?

@richardlau

richardlau commented Sep 4, 2018

Copy link
Copy Markdown
Member

Just heard about Chrome 69 stable is out, the v8 version comes with it have Lifeoff baseline compiler for WASM, could you use that version instead?

That's in progress in a separate PR: #21983

@lin7sh

lin7sh commented Sep 5, 2018

Copy link
Copy Markdown

@richardlau thanks for the link

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2018
jasnell
jasnell approved these changes Sep 5, 2018
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber-stamp lgtm

@danbev

danbev commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

Landed in 3295710.

@danbevdanbev closed this Sep 7, 2018
danbev pushed a commit that referenced this pull request Sep 7, 2018
@targos@danbev
deps: patch V8 to 6.8.275.32
3295710
PR-URL: #22682
Refs: v8/v8@6.8.275.30...6.8.275.32
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Sep 7, 2018
@targos
deps: patch V8 to 6.8.275.32
e85aa19
PR-URL: #22682
Refs: v8/v8@6.8.275.30...6.8.275.32
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Sep 18, 2018
Merged
@targos
targos deleted the v8-patch-32 branch October 17, 2020 12:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@nodejs-github-bot@lin7sh@richardlau@danbev@jasnell@BridgeAR