Uh oh!
There was an error while loading. Please reload this page.
src: fix trace-event-file-pattern description - #22690
Closed
AndreasMadsen wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Sep 4, 2018
Collaborator
@AndreasMadsen sadly an error occured when I tried to trigger a build :( |
This comment has been minimized.
This comment has been minimized.
addaleax
commented
Sep 5, 2018
Member
There’s a small difference – the “log-rotation id” bit. I guess removing that too makes sense, I just didn’t notice … so this just needs a rebase? |
AndreasMadsenforce-pushed
the
fix-pattern-description
branch
from
September 5, 2018 09:58
77de51e to
6cfc492CompareBridgeAR
approved these changes
Sep 5, 2018
BridgeAR
commented
Sep 5, 2018
Member
richardlau
approved these changes
Sep 5, 2018
Contributor
Rebuilding failing node-test-commit-freebsd |
danbev
commented
Sep 7, 2018
Contributor
Landed in 1a57ad2. |
danbev pushed a commit
that referenced
this pull request
Sep 7, 2018
PR-URL: #22690 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit
that referenced
this pull request
Sep 7, 2018
PR-URL: #22690 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
--trace-event-file-patterndescription undernode --helpChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes