Uh oh!
There was an error while loading. Please reload this page.
test: remove usage of deprecated V8 APIs in addons - #22704
Closed
targos wants to merge 1 commit into
Closed
Conversation
BridgeAR
approved these changes
Sep 5, 2018
BridgeAR
commented
Sep 5, 2018
Member
trivikr
approved these changes
Sep 5, 2018
jasnell
approved these changes
Sep 5, 2018
targos
commented
Sep 7, 2018
MemberAuthor
Landed in 8518548 |
targos added a commit
that referenced
this pull request
Sep 7, 2018
PR-URL: #22704 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit
that referenced
this pull request
Sep 7, 2018
PR-URL: #22704 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes