Uh oh!
There was an error while loading. Please reload this page.
tools: add [src] links to child-process.html - #22706
Closed
rubys wants to merge 1 commit into
Closed
Conversation
handle exports. as an alternative to module.exports
BridgeAR
approved these changes
Sep 5, 2018
jasnell
approved these changes
Sep 5, 2018
rubys
commented
Sep 8, 2018
MemberAuthor
rubys
commented
Sep 8, 2018
MemberAuthor
Landed in 8737683 |
rubys added a commit
to rubys/node
that referenced
this pull request
Sep 8, 2018
handle exports. as an alternative to module.exports PR-URL: nodejs#22706 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 9, 2018
handle exports. as an alternative to module.exports PR-URL: #22706 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle exports. as an alternative to module.exports
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes