Skip to content

doc: add apapirovski to TSC - #22717

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:add-anatoli-to-tsc
Closed

doc: add apapirovski to TSC#22717
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:add-anatoli-to-tsc

Conversation

@Trott

@TrottTrott commented Sep 5, 2018

Copy link
Copy Markdown
Member

@nodejs/tsc Please 👍 here to fast-track.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 5, 2018
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/806/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 5, 2018
@TrottTrott changed the title doc: add apapirovski to TSCCdoc: add apapirovski to TSCSep 5, 2018
mcollina
mcollina approved these changes Sep 5, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Sep 5, 2018

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/807/

@apapirovski

apapirovski commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

I probably shouldn't approve this but yay! 🎉 🙏

Trott added a commit to Trott/io.js that referenced this pull request Sep 5, 2018
@Trott
doc: add apapirovski to TSC
04195ad
PR-URL: nodejs#22717
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott

Trott commented Sep 5, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 04195ad

@TrottTrott closed this Sep 5, 2018
@apapirovskiapapirovski mentioned this pull request Sep 5, 2018
Closed
targos pushed a commit that referenced this pull request Sep 6, 2018
@Trott@targos
doc: add apapirovski to TSC
47acb78
PR-URL: #22717
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@TrottTrott added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 12, 2018
@targostargos mentioned this pull request Sep 18, 2018
Merged
@Trott
Trott deleted the add-anatoli-to-tsc branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
+2 more reviewers
@ofrobotsofrobotsofrobots approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott@nodejs-github-bot@apapirovski@mcollina@ofrobots@addaleax@TimothyGu@targos