Skip to content

tools: update eslint to v5.5.0 - #22720

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:update-eslint
Closed

tools: update eslint to v5.5.0#22720
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:update-eslint

Conversation

@BridgeAR

@BridgeARBridgeAR commented Sep 6, 2018

Copy link
Copy Markdown
Member

Update eslint from 5.4.0 to 5.5.0. The changeset is mainly deletions due to updating a couple dependencies.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/809/pipeline

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 6, 2018
trivikr
trivikr approved these changes Sep 6, 2018
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

jasnell
jasnell approved these changes Sep 6, 2018
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@silverwind

silverwind commented Sep 6, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Such a big diff again 😟. I wonder if we should attempt to bundle our dependencies like eslint to a single file using webpack, similar to how yarndoes it for their releases. cc: @nodejs/linting

@BridgeAR

BridgeAR commented Sep 6, 2018

Copy link
Copy Markdown
MemberAuthor

Since eslint is not platform specific it should not be required to run a full CI.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 6, 2018
@BridgeAR

BridgeAR commented Sep 6, 2018

Copy link
Copy Markdown
MemberAuthor

Bundling would be a good way. If I remember correct @refack wanted to address this with rollup.

@Trott

Trott commented Sep 6, 2018

Copy link
Copy Markdown
Member

tools/node_modules/eslint/node_modules/esprima/ChangeLog is included in this but it should have been deleted by dmn. Any idea what's up with that?

Other than that one thing, I get no diff when I update ESLint, so I'm 👍 on this, but please delete that one ChangeLog file.

@Trott

Trott commented Sep 6, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Such a big diff again 😟.

Yeah, that's why I decided not to open a PR when ESLint 5.5.0 came out. No new features that we're likely to use, and a big diff. (But that's not an objection from me! I'm OK with keeping it up to date just for the sake of having smaller diffs, even if some of them end up being disappointingly large anyway.)

@silverwind

silverwind commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

ChangeLog is included in this but it should have been deleted by dmn. Any idea what's up with that?

dnm only seems to search for Changelog, not ChangeLog, and its glob matching is performed case-sensitively. Suggesting to either change it to match insensitively or include ChangeLog.

@silverwind

silverwind commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

@Trottinikulin/dmn#12

@BridgeAR

BridgeAR commented Sep 8, 2018

Copy link
Copy Markdown
MemberAuthor

I just ran dmn@2 on this update and pushed the now deleted files in an extra commit.

@BridgeAR

BridgeAR commented Sep 9, 2018

Copy link
Copy Markdown
MemberAuthor

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/845/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 11, 2018
@BridgeAR
tools: update eslint to v5.5.0
623dcb7
PR-URL: nodejs#22720
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@BridgeAR

BridgeAR commented Sep 11, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 623dcb7 🎉

targos pushed a commit that referenced this pull request Sep 11, 2018
@BridgeAR@targos
tools: update eslint to v5.5.0
62d7304
PR-URL: #22720
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@targostargos mentioned this pull request Sep 18, 2018
Merged
@refackrefack mentioned this pull request Apr 25, 2019
Closed
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@silverwindsilverwindsilverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BridgeAR@nodejs-github-bot@silverwind@Trott@jasnell@trivikr