Skip to content

Update CHANGELOG_V10.md - #22744

Closed
chakravarthysm wants to merge 1 commit into
nodejs:masterfrom
chakravarthysm:patch-1
Closed

Update CHANGELOG_V10.md#22744
chakravarthysm wants to merge 1 commit into
nodejs:masterfrom
chakravarthysm:patch-1

Conversation

@chakravarthysm

@chakravarthysmchakravarthysm commented Sep 7, 2018

Copy link
Copy Markdown

Fix typo

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 7, 2018
@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 7, 2018
@targos

targos commented Sep 7, 2018

Copy link
Copy Markdown
Member

Thanks! The blog post should also be updated in the website's repo

@addaleax

addaleax commented Sep 7, 2018

Copy link
Copy Markdown
Member

Landed in e638bc5, thanks for the PR!

@addaleaxaddaleax closed this Sep 7, 2018
addaleax pushed a commit that referenced this pull request Sep 7, 2018
@chakravarthy-s-m@addaleax
doc: fix typo in CHANGELOG_V10.md
e638bc5
Fix typo
PR-URL: #22744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 7, 2018
@chakravarthy-s-m@targos
doc: fix typo in CHANGELOG_V10.md
e5cdfb0
Fix typo
PR-URL: #22744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targostargos mentioned this pull request Sep 18, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+2 more reviewers
@hiroppyhiroppyhiroppy approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@chakravarthysm@targos@addaleax@jasnell@lpinca@cjihrig@hiroppy@devsnek@BridgeAR@nodejs-github-bot@chakravarthy-s-m