Skip to content

build: make doc generation work on Windows - #22749

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:build-make-doc-generation-work-on-windows
Closed

build: make doc generation work on Windows#22749
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:build-make-doc-generation-work-on-windows

Conversation

@tniessen

@tniessentniessen commented Sep 7, 2018

Copy link
Copy Markdown
Member

#21697 broke doc generation on Windows since the option name for the output directory was incorrect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Sep 7, 2018
@tniessen

tniessen commented Sep 7, 2018

Copy link
Copy Markdown
MemberAuthor

Please 👍 here to approve fast-tracking.

@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2018

Copy link
Copy Markdown
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/823/pipeline

@refack

refack commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

/CC @nodejs/platform-windows @nodejs/build-files

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 8, 2018
@tniessen

tniessen commented Sep 8, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 3f67190.

@tniessentniessen closed this Sep 8, 2018
tniessen added a commit to tniessen/node that referenced this pull request Sep 8, 2018
@tniessen
build: make doc generation work on Windows
3f67190
PR-URL: nodejs#22749
Refs: nodejs#21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 9, 2018
@tniessen@targos
build: make doc generation work on Windows
a78a946
PR-URL: #22749
Refs: #21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Sep 18, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@refack@jasnell@richardlau@BridgeAR