Uh oh!
There was an error while loading. Please reload this page.
doc: fix description of DEP0024 - #22755
Closed
tniessen wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Sep 7, 2018
Collaborator
@tniessen sadly an error occured when I tried to trigger a build :( |
vsemozhetbyt
approved these changes
Sep 7, 2018
vsemozhetbyt
commented
Sep 7, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
jasnell
approved these changes
Sep 7, 2018
Trott
reviewed
Sep 7, 2018
| The `REPLServer.prototype.convertToContext()` API is deprecated and should | ||
| not be used. | ||
| The `REPLServer.prototype.convertToContext()` API has been removed | ||
| and cannot be used anymore. |
Member
There was a problem hiding this comment.
Suggestions, feel free to ignore: Remove anymore? Or even just end the sentence after removed?
Trott
approved these changes
Sep 7, 2018
ZYSzys
approved these changes
Sep 8, 2018
lpinca
approved these changes
Sep 8, 2018
tniessen
commented
Sep 8, 2018
MemberAuthor
Landed in 9f06a05. |
tniessen added a commit
that referenced
this pull request
Sep 8, 2018
PR-URL: #22755 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 9, 2018
PR-URL: #22755 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was removed in #13434.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes