Uh oh!
There was an error while loading. Please reload this page.
doc: fix type of DEP0116 - #22765
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
vsemozhetbyt
approved these changes
Sep 8, 2018
vsemozhetbyt
commented
Sep 8, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
cjihrig
approved these changes
Sep 9, 2018
Trott
approved these changes
Sep 9, 2018
Trott
commented
Sep 9, 2018
Member
Someone was kind enough to re-run the Lite CI pipeline for this: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/835/pipeline/ All green this time. |
Trott
commented
Sep 9, 2018
Member
Landed in 67ba8ff |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 9, 2018
PR-URL: nodejs#22765 Refs: nodejs#22715 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other deprecations use the term
Documentation-onlywhere applicable.Refs: #22715
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes