src: fix `--prof-process` CLI argument handling by addaleax · Pull Request #22790 · nodejs/node

addaleax · 2018-09-10T10:09:26Z

Make sure that options after --prof-process are not treated
as Node.js options.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Make sure that options after `--prof-process` are not treated as Node.js options. Fixes: nodejs#22786

nodejs-github-bot · 2018-09-10T10:10:22Z

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/850/pipeline

addaleax · 2018-09-10T10:16:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17100/

joyeecheung · 2018-09-10T10:43:07Z

+assert(logfile);
+
+// Make sure that the --preprocess argument is passed through correctly.
+const { stdout } = spawnSync(


Maybe a note here about any arguments accepted by deps/v8/tools/tickprocessor.js would do in case V8 removes that in the future?

Yup, done (and also fixed CI a bit) :)

mcollina · 2018-09-10T11:04:28Z

I can confirm this fixes the problem for 0x.

mcollina

LGTM

addaleax · 2018-09-10T11:05:03Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/17101/

richardlau · 2018-09-10T12:55:01Z

I think we should note in https://github.com/nodejs/node/blob/master/doc/api/cli.md#--prof-process and https://github.com/nodejs/node/blob/master/doc/node.1 about the processing of subsequent options.

addaleax · 2018-09-10T13:02:08Z

@richardlau Would a follow-up PR be okay? I’d also like to make --prof-process --help work, and it would be good to be able to refer to that (I don’t think it has ever worked in Node.js)

richardlau · 2018-09-10T13:04:27Z

Would a follow-up PR be okay? I’d also like to make --prof-process --help work, and it would be good to be able to refer to that (I don’t think it has ever worked in Node.js)

👍 Fine by me.

mcollina · 2018-09-10T13:43:50Z

Can we fast-track this and getting it into a release asap?

targos · 2018-09-10T14:18:11Z

@mcollina Are you asking for a release sooner than usual (i.e. this week instead of the next one)?

mcollina · 2018-09-10T15:09:05Z

If possible, yes. If no one is available to do it, it's not a big deal (next week is also ok). A significant number of flamegraph tools (not just clinic) are broken because of this.

addaleax · 2018-09-11T11:10:17Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/17116/

addaleax · 2018-09-12T10:39:22Z

I pushed a commit to skip the test on AIX completely; not sure why it’s failing there. (/cc @nodejs/platform-aix)

CI: https://ci.nodejs.org/job/node-test-pull-request/17131/

richardlau · 2018-09-13T17:29:11Z

I pushed a commit to skip the test on AIX completely; not sure why it’s failing there. (/cc @nodejs/platform-aix)

There's this comment in the tick-processor tests:

node/test/tick-processor/test-tick-processor-unknown.js

Lines 4 to 10 in 19c0620

// TODO(mhdawson) Currently the test-tick-processor functionality in V8
// depends on addresses being smaller than a full 64 bits. AIX supports
// the full 64 bits and the result is that it does not process the
// addresses correctly and runs out of memory
// Disabling until we get a fix upstreamed into V8
if(common.isAIX)
common.skip('AIX address range too big for scripts.');

addaleax · 2018-09-13T21:25:15Z

@richardlau Okay, thanks – makes sense!

targos · 2018-09-14T12:59:31Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/17186/

Rebuild Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20732/
Rebuild Linux: https://ci.nodejs.org/job/node-test-commit-linux/21563/

targos · 2018-09-16T07:45:12Z

Landed in 23f8b02

Make sure that options after `--prof-process` are not treated as Node.js options. Fixes: #22786 PR-URL: #22790 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

src: fix --prof-process CLI argument handling
d86e38e
Make sure that options after `--prof-process` are not treated as Node.js options. Fixes: nodejs#22786

addaleax requested a review from bengl September 10, 2018 10:09

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 10, 2018

addaleax mentioned this pull request Sep 10, 2018
--prof-process CLI args no longer work in 10.10.0 #22786
Closed

addaleax added the cli Issues and PRs related to the Node.js command line interface. label Sep 10, 2018

joyeecheung approved these changes Sep 10, 2018
View reviewed changes

fixup! src: fix --prof-process CLI argument handling
496e215

mcollina approved these changes Sep 10, 2018
View reviewed changes

cjihrig approved these changes Sep 10, 2018
View reviewed changes

jasnell approved these changes Sep 10, 2018
View reviewed changes

BridgeAR approved these changes Sep 10, 2018
View reviewed changes

addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 10, 2018

bengl approved these changes Sep 10, 2018
View reviewed changes

addaleax mentioned this pull request Sep 11, 2018
fs: ensure readdir() callback is only called once #22793
Closed
2 tasks

fixup! src: fix --prof-process CLI argument handling
fe0949f

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 11, 2018

trivikr approved these changes Sep 11, 2018
View reviewed changes

fixup! src: fix --prof-process CLI argument handling
5348ef3

trivikr approved these changes Sep 15, 2018
View reviewed changes

targos closed this Sep 16, 2018

addaleax deleted the fix-prof-process branch September 16, 2018 07:46

targos mentioned this pull request Sep 18, 2018
Release proposal: v10.11.0 #22932
Merged

mcollina mentioned this pull request Sep 20, 2018
Bump node-clinic to tier 3 nodejs/diagnostics#234
Closed

Uh oh!

Uh oh!

Conversation

addaleax commented Sep 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Sep 10, 2018

Uh oh!

addaleax commented Sep 10, 2018

Uh oh!

joyeecheungSep 10, 2018

Choose a reason for hiding this comment

Uh oh!

addaleaxSep 10, 2018

Choose a reason for hiding this comment

Uh oh!

mcollina commented Sep 10, 2018

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented Sep 10, 2018

Uh oh!

richardlau commented Sep 10, 2018

Uh oh!

addaleax commented Sep 10, 2018

Uh oh!

richardlau commented Sep 10, 2018

Uh oh!

mcollina commented Sep 10, 2018

Uh oh!

targos commented Sep 10, 2018

Uh oh!

mcollina commented Sep 10, 2018

Uh oh!

addaleax commented Sep 11, 2018

Uh oh!

addaleax commented Sep 12, 2018

Uh oh!

richardlau commented Sep 13, 2018

Uh oh!

addaleax commented Sep 13, 2018

Uh oh!

targos commented Sep 14, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Sep 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

addaleax commented Sep 10, 2018•
edited
Loading

targos commented Sep 14, 2018•
edited
Loading