tools,win: fix find_python error

[kfarnung]

On a machine without python.exe in the PATH the script was failing
with:

> .\vcbuild.batLooking for Python 2.x2> was unexpected at this time.

Escaping the > seems to resolve it.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@kfarnung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/855/pipeline

[richardlau]

cc @nodejs/platform-windows

[refack]

I did some local testing and found that b6e991d is required as well.

[kfarnung]

Oh, interesting, what was the symptom there? I only have Python 2.7 installed on this machine (but not in the PATH), so it's possible that I didn't run into that issue.

[refack]

Oh, interesting, what was the symptom there? I only have Python 2.7 installed on this machine (but not in the PATH), so it's possible that I didn't run into that issue.

I had both 3.7 & 2.7 (and none in the Path), and I found that the path is not propagated

FOR /F "tokens=3*" %b IN ('REG QUERY HKEY_CURRENT_USER\Software\Python\PythonCore\2.7\InstallPath /ve') DO (
SET pt=%b
IF NOT ERRORLEVEL 1 SET p=
EXIT /B 0
)

in the full

Details

D:\code\node>call tools\msvs\find_python.cmd
echo Looking for Python 2.x
Looking for Python 2.x
SETLOCAL
FOR /F "delims=" %a IN ('where python 2> NUL') DO (
SET need_path=0
SET p=%~dpa
IF NOT ERRORLEVEL 1 GOTO :validate
)
FOR %K IN ("HKCU\Software" "HKLM\SOFTWARE" "HKLM\Software\Wow6432Node") DO (
SET need_path=1
CALL :find-main-branch %K
IF NOT ERRORLEVEL 1 GOTO :validate
)
(
SET need_path=1
CALL :find-main-branch "HKCU\Software"
IF NOT ERRORLEVEL 1 GOTO :validate
)
SET main_key="HKCU\Software\Python\PythonCore"
REG QUERY "HKCU\Software\Python\PythonCore" /s 2>NUL | findstr "2." | findstr InstallPath 1>NUL 2>NUL
IF NOT ERRORLEVEL 1 CALL :find-key "HKCU\Software\Python\PythonCore"
FOR /F "delims=" %a IN ('REG QUERY "HKCU\Software\Python\PythonCore" /s 2> NUL | findstr "2." | findstr InstallPath') DO IF NOT ERRORLEVEL 1 CALL :find-path %a
IF NOT ERRORLEVEL 1 CALL :find-path HKEY_CURRENT_USER\Software\Python\PythonCore\2.7\InstallPath
FOR /F "tokens=3*" %b IN ('REG QUERY HKEY_CURRENT_USER\Software\Python\PythonCore\2.7\InstallPath /ve') DO (
SET pt=%b
IF NOT ERRORLEVEL 1 SET p=
EXIT /B 0
)
(
SET pt=D:\bin\dev\python27\
IF NOT ERRORLEVEL 1 SET p=
EXIT /B 0
)
EXIT /B
EXIT /B
IF NOT EXIST "python.exe" goto :no-python
echo Could not find Python.
Could not find Python.
exit /B 1

P.S. Let me test it a little bit more...

[kfarnung]

I appreciate the help testing this out, I suspect this code doesn't get too much exercise.

[addaleax]

@kfarnung@refack What’s the status? Is this good to go?

[kfarnung]

I think my fix is good either way, AFAICT the script is completely broken without the fix (if you don't have python.exe in your path).

@refack, did you get a chance to determine whether your fix was necessary? Any issues you've come across.

I'm inclined to land this today as long as the CI looks good and there are no objections. We can tweak this further if people hit other issues.

[kfarnung]

Rebased and merged @refack's commits together. Will kick off a CI if Jenkins responds.

[kfarnung]

@refack, trying it out again today, it seems like your change causes my machine to not find Python at all.

[kfarnung]

CI: https://ci.nodejs.org/job/node-test-pull-request/17262/

[kfarnung]

@nodejs/platform-windows @refack any issues with this change? I'd like to get another sign-off and check this in today if there are no objections. We can circle back on @refack's issue in a future PR.

[refack]

We can circle back on @refack's issue in a future PR.

Ok.

[refack]

@kfarnung does the > .\vcbuild.bat hint that you are running this from PowerShell?
For me to test this further, could you also paste your set before running, so I can reproduce. Also might help a run of vcbuild with set DEFINED DEBUG_HELPER=1, and reg QUERY HKEY_CURRENT_USER\Software\Python /S

[kfarnung]

I do use PowerShell most of the time, but both CMD and PowerShell exhibit the same behavior (that's fixed by my change). I have Python 2.7 installed in C:\Python27 and Python 3.7 installed to my user folder. I ran the reg queries for HKCU and HKLM: reg_python.txt.

Here's the output of before (vcbuild_before.txt) and after (vcbuild_fixed.txt) my fix.

[kfarnung]

Resumed Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20796/

[refack]

I ran the reg queries for HKCU and HKLM: reg_python.txt.

That was wise, I see the edge case, you have 3.7 only in HKCU and 2.7 only in HKLM...
I think the search loops cascade, and not nest. It's a good test case.

[kfarnung]

I suspected that might be the case. Given that I have a clean CI now, would you be ok with my landing this PR?

[refack]

I suspected that might be the case. Given that I have a clean CI now, would you be ok with my landing this PR?

Sure, if it fixes your system, it's definatly an improvement.

[kfarnung]

Thanks! Just for reference, how do you have Python installed? Are they both under HKCU?

[refack]

Just for reference, how do you have Python installed? Are they both under HKCU?

Yes, but I hand roll my setup. I use
Python.reg.txt
And xcopy the files (sometimes I need to use https://github.com/Bioruebe/UniExtract2)

P.S.
I usually remove those entries when I do test, but I'm going to mock out reg.exe for a test harness.

[kfarnung]

Landed in 988be43