Uh oh!
There was an error while loading. Please reload this page.
doc: add gabrielschulhof to TSC - #22818
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Sep 12, 2018
MemberAuthor
@nodejs/tsc Please 👍 here to fast-track. |
nodejs-github-bot
commented
Sep 12, 2018
Collaborator
@Trott sadly an error occured when I tried to trigger a build :( |
cjihrig
approved these changes
Sep 12, 2018
addaleax
approved these changes
Sep 12, 2018
targos
approved these changes
Sep 12, 2018
Trott
commented
Sep 12, 2018
MemberAuthor
Was unable to start a lite CI job, so I started a full CI: https://ci.nodejs.org/job/node-test-pull-request/17139/ |
gireeshpunathil
approved these changes
Sep 12, 2018
TimothyGu
approved these changes
Sep 12, 2018
jasnell
approved these changes
Sep 12, 2018
Trott
commented
Sep 12, 2018
MemberAuthor
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/865/ Linter looks like it's out of commission at the moment. Job should get a replay when it's fixed. |
MemberAuthor
Looks like @refack fixed the linter and initiated a re-run. 🎉 ❤️ |
richardlau
approved these changes
Sep 12, 2018
joyeecheung
approved these changes
Sep 12, 2018
apapirovski
approved these changes
Sep 12, 2018
Trott added a commit
to Trott/io.js
that referenced
this pull request
Sep 13, 2018
PR-URL: nodejs#22818 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Trott
commented
Sep 13, 2018
MemberAuthor
Landed in 82b752a |
targos pushed a commit
that referenced
this pull request
Sep 14, 2018
PR-URL: #22818 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit
that referenced
this pull request
Sep 19, 2018
PR-URL: #22818 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit
that referenced
this pull request
Sep 20, 2018
PR-URL: #22818 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes