http2: add http2stream.endAfterHeaders property by jasnell · Pull Request #22843 · nodejs/node

jasnell · 2018-09-13T16:33:34Z

Indicates is the END_STREAM flag was set on the received HEADERS frame

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Indicates is the END_STREAM flag was set on the received HEADERS frame

nodejs-github-bot · 2018-09-13T16:33:39Z

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/880/pipeline

jasnell · 2018-09-13T16:34:31Z

Refs: #22497

dougwilson · 2018-09-13T16:40:39Z

Nice! Is this available in the compat API or just the http2 API?

jasnell · 2018-09-13T16:46:51Z

In the compat API you would access via `req.stream.endAfterHeaders` On Sep 13, 2018 17:41, "Douglas Wilson" <notifications@github.com> wrote: Nice! Is this available in the compat API or just the http2 API? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22843 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2eTsNp4sf4_vfVbrajhSSwIBILO9Gks5uaoq9gaJpZM4WntWQ> .

mcollina

LGTM

vsemozhetbyt · 2018-09-13T18:11:45Z

+
+* {boolean}
+
+Set the `true` if the `END_STREAM` flag was set in the request or response


Set the -> Set to?

vsemozhetbyt · 2018-09-13T18:15:43Z

+* {boolean}
+
+Set the `true` if the `END_STREAM` flag was set in the request or response
+HEADERS frame received, indicating that no additional data should be received


HEADERS -> `HEADERS`?

trivikr · 2018-09-15T04:43:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17202/

mcollina · 2018-09-17T08:18:22Z

~~CI: https://ci.nodejs.org/job/node-test-pull-request/17224/~~
CI: https://ci.nodejs.org/job/node-test-pull-request/17239/

addaleax · 2018-09-17T15:08:59Z

Landed in efe0bbc

Indicates is the END_STREAM flag was set on the received HEADERS frame PR-URL: #22843Fixes: #22497 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * fs * Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If this option is set to `true`, non-existing parent folders will be automatically created. #21875 * Fixed fsPromises.readdir `withFileTypes`. #22832 * http2 * Added `http2stream.endAfterHeaders` property. #22843 * module * Added `module.createRequireFromPath(filename)`. This new method can be used to create a custom `require` function that will resolve modules relative to the `filename` path. #19360 * url * Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These methods can be used to correctly convert between `file:` URLs and absolute paths. #22506 * util * Added `util.types.isBoxedPrimitive(value)`. #22620 * Windows * The Windows msi installer now provides an option to automatically install the tools required to build native modules. #22645 * Added new collaborators: * boneskull (https://github.com/boneskull) - Christopher Hiller * The Technical Steering Committee has new members: * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof PR-URL: #22932

Indicates is the END_STREAM flag was set on the received HEADERS frame PR-URL: #22843Fixes: #22497 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * fs * Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If this option is set to `true`, non-existing parent folders will be automatically created. #21875 * Fixed fsPromises.readdir `withFileTypes`. #22832 * http2 * Added `http2stream.endAfterHeaders` property. #22843 * module * Added `module.createRequireFromPath(filename)`. This new method can be used to create a custom `require` function that will resolve modules relative to the `filename` path. #19360 * url * Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These methods can be used to correctly convert between `file:` URLs and absolute paths. #22506 * util * Added `util.types.isBoxedPrimitive(value)`. #22620 * Added new collaborators: * boneskull (https://github.com/boneskull) - Christopher Hiller * The Technical Steering Committee has new members: * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof PR-URL: #22932

Indicates is the END_STREAM flag was set on the received HEADERS frame PR-URL: #22843Fixes: #22497 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * fs * Fixed fsPromises.readdir `withFileTypes`. #22832 * http2 * Added `http2stream.endAfterHeaders` property. #22843 * util * Added `util.types.isBoxedPrimitive(value)`. #22620 * Added new collaborators: * boneskull (https://github.com/boneskull) - Christopher Hiller * The Technical Steering Committee has new members: * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof PR-URL: #22932

Indicates is the END_STREAM flag was set on the received HEADERS frame PR-URL: nodejs#22843Fixes: nodejs#22497 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Indicates is the END_STREAM flag was set on the received HEADERS frame Backport-PR-URL: #22850 PR-URL: #22843Fixes: #22497 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

http2: add http2stream.endAfterHeaders property
0a9b77c
Indicates is the END_STREAM flag was set on the received HEADERS frame

nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 13, 2018

jasnell added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. and removed dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 13, 2018

jasnell mentioned this pull request Sep 13, 2018
HTTP2: API for checking if http2ServerRequest had body frame. #22497
Closed

mcollina approved these changes Sep 13, 2018
View reviewed changes

vsemozhetbyt reviewed Sep 13, 2018
View reviewed changes

addaleax approved these changes Sep 14, 2018
View reviewed changes

trivikr approved these changes Sep 15, 2018
View reviewed changes

cjihrig approved these changes Sep 16, 2018
View reviewed changes

mcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. labels Sep 17, 2018

addaleax removed the needs-ci PRs that need a full CI run. label Sep 17, 2018

addaleax closed this Sep 17, 2018

targos mentioned this pull request Sep 18, 2018
Release proposal: v10.11.0 #22932
Merged

This was referenced Sep 18, 2018
CI failures: 20180918 nodejs/reliability#16
Closed
Investigate flaky test-worker-syntax-error-file #22762
Closed

sogaani mentioned this pull request Sep 21, 2018
Support http2 jshttp/type-is#36
Closed

BethGriggs mentioned this pull request Oct 30, 2018
v8.13.0 proposal #23974
Merged

beevelop mentioned this pull request Nov 20, 2018
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250
Closed

Navigation Menu

Uh oh!

Uh oh!

http2: add http2stream.endAfterHeaders property - #22843

http2: add http2stream.endAfterHeaders property#22843
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-add-endafterheaders

jasnell commented Sep 13, 2018

Uh oh!

nodejs-github-bot commented Sep 13, 2018

Uh oh!

jasnell commented Sep 13, 2018

Uh oh!

dougwilson commented Sep 13, 2018

Uh oh!

jasnell commented Sep 13, 2018 via email

Uh oh!

mcollina left a comment

Uh oh!

vsemozhetbytSep 13, 2018

Uh oh!

vsemozhetbytSep 13, 2018

Uh oh!

trivikr commented Sep 15, 2018

Uh oh!

mcollina commented Sep 17, 2018•
edited
Loading

Uh oh!

addaleax commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants


		* {boolean}

		Set the `true` if the `END_STREAM` flag was set in the request or response

Uh oh!

Uh oh!

Conversation

jasnell commented Sep 13, 2018

Checklist

Uh oh!

nodejs-github-bot commented Sep 13, 2018

Uh oh!

jasnell commented Sep 13, 2018

Uh oh!

dougwilson commented Sep 13, 2018

Uh oh!

jasnell commented Sep 13, 2018 via email

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

vsemozhetbytSep 13, 2018

Choose a reason for hiding this comment

Uh oh!

vsemozhetbytSep 13, 2018

Choose a reason for hiding this comment

Uh oh!

trivikr commented Sep 15, 2018

Uh oh!

mcollina commented Sep 17, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mcollina commented Sep 17, 2018•
edited
Loading