Skip to content

http2: check if stream is not destroyed before sending trailers - #22896

Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-22855
Closed

http2: check if stream is not destroyed before sending trailers#22896
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-22855

Conversation

@mcollina

@mcollinamcollina commented Sep 17, 2018

Copy link
Copy Markdown
Member

Fixes#22855.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2018

Copy link
Copy Markdown
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/904/pipeline

@nodejs-github-botnodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 17, 2018
@mcollinamcollina mentioned this pull request Sep 17, 2018
Closed
@mcollina

mcollina commented Sep 17, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/17230/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2018
@mcollina

mcollina commented Sep 19, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in c9d4304

@mcollina
mcollina deleted the fix-22855 branch September 19, 2018 15:35
mcollina added a commit that referenced this pull request Sep 19, 2018
@mcollina
http2: check if stream is not destroyed before sending trailers
c9d4304
Fixes: #22855
PR-URL: #22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sogaanisogaani mentioned this pull request Sep 20, 2018
Open
5 tasks
targos pushed a commit that referenced this pull request Sep 20, 2018
@mcollina@targos
http2: check if stream is not destroyed before sending trailers
89fe9ed
Fixes: #22855
PR-URL: #22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 3, 2018
@mcollina@kjin
http2: check if stream is not destroyed before sending trailers
57ac6a5
Fixes: nodejs#22855
PR-URL: nodejs#22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@mcollina@kjin
http2: check if stream is not destroyed before sending trailers
2fd285a
Fixes: nodejs#22855
PR-URL: nodejs#22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@mcollina@BethGriggs
http2: check if stream is not destroyed before sending trailers
9f79341
Fixes: #22855
Backport-PR-URL: #22850
PR-URL: #22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@apapirovskiapapirovskiAwaiting requested review from apapirovski

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@jasnell@cjihrig@BridgeAR