Uh oh!
There was an error while loading. Please reload this page.
[v10.x backport] deps: cherry-pick 9a23bdd from upstream V8 - #22910
Closed
Drieger wants to merge 1 commit into
Closed
[v10.x backport] deps: cherry-pick 9a23bdd from upstream V8#22910Drieger wants to merge 1 commit into
Drieger wants to merge 1 commit into
Conversation
Driegerforce-pushed
the
backport-22338-to-v10.x
branch
3 times, most recently
from
September 17, 2018 18:05
7876bc6 to
b76f5f7CompareDriegerforce-pushed
the
backport-22338-to-v10.x
branch
from
September 17, 2018 19:11
b76f5f7 to
66bf218CompareDrieger
commented
Sep 17, 2018
ContributorAuthor
@mmarchini Updated commit message to match the correct format. |
Driegerforce-pushed
the
backport-22338-to-v10.x
branch
from
September 17, 2018 19:27
66bf218 to
bf9f693CompareContributor
richardlau
previously requested changes
Sep 17, 2018
richardlau
left a comment
Member
There was a problem hiding this comment.
For v10.x v8_embedder_string in common.gypi should be incremented instead of the V8 patch level: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md
Original commit message: [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames Previously we were getting the code object from the stack, so printed incorrect position details for interpreted frames. BUG=v8:7916 Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9 Reviewed-on: https://chromium-review.googlesource.com/1126313 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#54253} Refs: nodejs#21988
Driegerforce-pushed
the
backport-22338-to-v10.x
branch
from
September 18, 2018 10:42
bf9f693 to
c0aa2d0CompareDrieger
commented
Sep 18, 2018
ContributorAuthor
@richardlau Updated |
targos
approved these changes
Sep 18, 2018
targos
commented
Sep 18, 2018
Member
Refs: v8/v8@9a23bdd |
targos
commented
Sep 19, 2018
Member
Landed in 0f99b8d4bd693c859ef5a954c5b0efdd4c1c95a8 |
targos pushed a commit
that referenced
this pull request
Sep 19, 2018
Original commit message: [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames Previously we were getting the code object from the stack, so printed incorrect position details for interpreted frames. BUG=v8:7916 Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9 Reviewed-on: https://chromium-review.googlesource.com/1126313 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54253} Refs: v8/v8@9a23bdd Refs: #21988 PR-URL: #22910 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit
that referenced
this pull request
Sep 20, 2018
Original commit message: [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames Previously we were getting the code object from the stack, so printed incorrect position details for interpreted frames. BUG=v8:7916 Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9 Reviewed-on: https://chromium-review.googlesource.com/1126313 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54253} Refs: v8/v8@9a23bdd Refs: #21988 PR-URL: #22910 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were getting the code object from the stack, so printed incorrect
position details for interpreted frames.
BUG=v8:7916
Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
Reviewed-on: https://chromium-review.googlesource.com/1126313
Reviewed-by: Toon Verwaest verwaest@chromium.org
Commit-Queue: Ross McIlroy rmcilroy@chromium.org
Cr-Commit-Position: refs/heads/master@{#54253}
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes