Skip to content

doc: add boneskull as collaborator - #22917

Closed
boneskull wants to merge 1 commit into
nodejs:masterfrom
boneskull:onboarding
Closed

doc: add boneskull as collaborator#22917
boneskull wants to merge 1 commit into
nodejs:masterfrom
boneskull:onboarding

Conversation

@boneskull

@boneskullboneskull commented Sep 17, 2018•
edited by tniessen
Loading

Copy link
Copy Markdown
Member

woo!

Checklist

@boneskullboneskull added doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 17, 2018
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2018

Copy link
Copy Markdown
Collaborator

@boneskull build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/916/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 17, 2018
Trott
Trott approved these changes Sep 17, 2018
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 to fast-tracking.

@boneskull

boneskull commented Sep 17, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/17264/

@tniessen

tniessen commented Sep 17, 2018

Copy link
Copy Markdown
Member

I approve fast-tracking.

devsnek
devsnek approved these changes Sep 17, 2018
View reviewed changes

@devsnekdevsnek left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome aboard! :shipit:

@vsemozhetbytvsemozhetbyt added meta Issues and PRs related to the general management of the project. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 17, 2018
@boneskull

boneskull commented Sep 17, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 8df13ec

@boneskull
boneskull deleted the onboarding branch September 17, 2018 21:46
boneskull added a commit that referenced this pull request Sep 17, 2018
@boneskull
doc: add boneskull as collaborator
8df13ec
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 18, 2018
@boneskull@targos
doc: add boneskull as collaborator
da2c303
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targostargos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@boneskull@targos
doc: add boneskull as collaborator
97f6ff3
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 20, 2018
@boneskull@targos
doc: add boneskull as collaborator
6e9f1d6
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@tniessentniessentniessen approved these changes
+2 more reviewers
@devsnekdevsnekdevsnek approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@boneskull@nodejs-github-bot@tniessen@Trott@devsnek@vsemozhetbyt