Skip to content

build: make config verbose on CI - #22935

Merged
refack merged 1 commit into
masterfrom
config-verbose-in-CI
Sep 21, 2018
Merged

build: make config verbose on CI#22935
refack merged 1 commit into
masterfrom
config-verbose-in-CI

Conversation

@refack

@refackrefack commented Sep 18, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Sep 18, 2018
@refackrefack added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 18, 2018
@refack

Copy link
Copy Markdown
ContributorAuthor

Ohh sorry I created the branch on this repo. I'm hoping to fast track this, so we won't miss information in CI.

/CC @nodejs/build-files

Comment threadvcbuild.bat
if defined config_flags set configure_flags=%configure_flags% %config_flags%
if defined target_arch set configure_flags=%configure_flags% --dest-cpu=%target_arch%
if defined openssl_no_asm set configure_flags=%configure_flags% --openssl-no-asm
if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this set on the CI?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now ;)

@refack

Copy link
Copy Markdown
ContributorAuthor

@refack

Copy link
Copy Markdown
ContributorAuthor

From a windows machine:

15:05:23 configure --with-ltcg --dest-cpu=x64 --verbose
15:05:26 creating icu_config.gypi
15:05:26 * Using ICU in deps/icu-small
15:05:26 creating icu_config.gypi
15:05:26 { 'target_defaults': { 'cflags': [],
15:05:26 'default_configuration': 'Release',
15:05:26 'defines': [],
15:05:26 'include_dirs': [],
15:05:26 'libraries': []},

From a POSIX machine:

python ./configure --verbose --dest-cpu=ppc64
creating icu_config.gypi
* Using ICU in deps/icu-small
creating icu_config.gypi
{ 'target_defaults': { 'cflags': [],
'default_configuration': 'Release',
'defines': [],
'include_dirs': [],
'libraries': []},

@richardlau

Copy link
Copy Markdown
Member

For reference, this restores verbose output from configure that was suppressed by #22450. Having the output from configure is useful for things like #22934 (comment) (the alternative is looking at config.gypi in the job's workspace, but that is only valid for the most recent run of the job).

PR-URL: #22935
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack
refackforce-pushed the config-verbose-in-CI branch from 9fe3d1a to c55ebd8CompareSeptember 21, 2018 20:21
@refack

Copy link
Copy Markdown
ContributorAuthor

landed in c55ebd8

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@nodejs-github-bot@richardlau@jasnell@joyeecheung