Skip to content

deps: upgrade to libuv 1.23.1 - #22997

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:libuv
Closed

deps: upgrade to libuv 1.23.1#22997
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:libuv

Conversation

@cjihrig

@cjihrigcjihrig commented Sep 21, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2018

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/957/pipeline

@nodejs-github-botnodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Sep 21, 2018
@addaleaxaddaleax mentioned this pull request Sep 21, 2018
Closed
addaleax
addaleax approved these changes Sep 21, 2018
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: https://github.com/nodejs/node/issues/22814

@addaleax

addaleax commented Sep 21, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17356/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2018
mcollina
mcollina approved these changes Sep 21, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax

addaleax commented Sep 22, 2018

Copy link
Copy Markdown
Member

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20943/

BridgeAR
BridgeAR approved these changes Sep 23, 2018
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@danbev

danbev commented Sep 24, 2018

Copy link
Copy Markdown
Contributor

Landed in 2790db5.

@danbevdanbev closed this Sep 24, 2018
danbev pushed a commit that referenced this pull request Sep 24, 2018
@cjihrig@danbev
deps: upgrade to libuv 1.23.1
2790db5
PR-URL: #22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 24, 2018
@cjihrig@targos
deps: upgrade to libuv 1.23.1
e5efdba
PR-URL: #22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gireeshpunathilgireeshpunathil mentioned this pull request Sep 25, 2018
Closed
@joyeecheungjoyeecheung mentioned this pull request Sep 25, 2018
Closed
@Trott

Trott commented Oct 4, 2018

Copy link
Copy Markdown
Member

After talking a bit with @addaleax, I did a bisect using a series of stress tests to determine what commit introduced the unreliability for test-gc-net-timeout (and likely the other test-gc-* files). Unfortunately, the commit where the problem was introduced is the one in this PR.

Ref: https://gist.github.com/Trott/d3c3b5e4419497fdc8651ac2d5f805c7

@addaleax

addaleax commented Oct 4, 2018

Copy link
Copy Markdown
Member

Went through the individual libuv commits in nodejs/reliability#18 (comment)

@targostargos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Nov 5, 2018
@cjihrig@MylesBorins
deps: upgrade to libuv 1.23.1
a31819a
PR-URL: nodejs#22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2018
@cjihrig@MylesBorins
deps: upgrade to libuv 1.23.1
b38190e
Backport-PR-URL: #24103
PR-URL: #22997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggsBethGriggs mentioned this pull request Nov 12, 2018
Merged
@Fishrock123Fishrock123 mentioned this pull request Nov 15, 2018
Closed
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
@shuheishuhei mentioned this pull request Jan 19, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.libuvIssues and PRs related to the libuv dependency or the uv binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjihrig@nodejs-github-bot@addaleax@danbev@Trott@mcollina@jasnell@BridgeAR